Closed ShivanKaul closed 2 months ago
Adblock on iOS is controlled by component updater as well, so a possible solution here would be to expose a way to access brave://components
on iOS as well
We should look at the Android implementation of this, at least for the placement of the Update button: https://github.com/brave/brave-browser/issues/35270. It would be best if this button lived in the Content Filtering settings page.
Verified on iPhone 12
running iOS 18.0
using version 1.70.117
Case: New Users
Update Lists
button is shown for Default Filter Lists and External Filter Lists. Update Lists
button is only shown for External Filters Lists when URLs are added and not shown when URLs are removed again. Lists Updated
message when tapping on the update button. Update Lists
) when re-entering the settings page. example | example | example | example | example | example |
---|---|---|---|---|---|
Case: Existing Users
Block 'Switch to App' Notices
in settings and then upgrading will retain the switch state in Content Filtering and Settings page. Update Lists
button works after upgrading for existing users and updated
message is shown.example | example | example | example |
---|---|---|---|
Verified on iPad (7th Gen)
running iOS 17.6
using version 1.70.117
Case: New Users
Update Lists
button is shown for Default Filter Lists and External Filter Lists. Update Lists
button is only shown for External Filters Lists when URLs are added and not shown when URLs are removed again. Lists Updated
message when tapping on the update button. Update Lists
) when re-entering the settings page. example | example | example | example |
---|---|---|---|
Case: Existing Users
Block 'Switch to App' Notices
in settings and then upgrading will retain the switch state in Content Filtering and Settings page. Update Lists
button works after upgrading for existing users and updated
message is shown.example | example | example |
---|---|---|
We don't currently have a way on iOS to force-update all components like we do on Desktop and Android, where a user can go to brave://components in the omnibox and manually press Update for components.
This is extremely important for when we need to ship an emergency component update out, like we do when there's widespread adblock list-related breakage. On iOS, AFAICT, there's nothing a user can do to make sure they have the latest version of an adblock list.
We don't need to have the update be per-component; a single button suffice somewhere in the app would suffice. For debugging purposes, it would also be nice to know the user's current version, but that's secondary in priority.