brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.65k stars 2.3k forks source link

Have a way to force-update adblock lists #35982

Closed ShivanKaul closed 2 months ago

ShivanKaul commented 9 months ago

We don't currently have a way on iOS to force-update all components like we do on Desktop and Android, where a user can go to brave://components in the omnibox and manually press Update for components.

image

This is extremely important for when we need to ship an emergency component update out, like we do when there's widespread adblock list-related breakage. On iOS, AFAICT, there's nothing a user can do to make sure they have the latest version of an adblock list.

We don't need to have the update be per-component; a single button suffice somewhere in the app would suffice. For debugging purposes, it would also be nice to know the user's current version, but that's secondary in priority.

kylehickinson commented 9 months ago

Adblock on iOS is controlled by component updater as well, so a possible solution here would be to expose a way to access brave://components on iOS as well

ShivanKaul commented 3 months ago

We should look at the Android implementation of this, at least for the placement of the Update button: https://github.com/brave/brave-browser/issues/35270. It would be best if this button lived in the Content Filtering settings page.

Uni-verse commented 2 weeks ago

Verified on iPhone 12 running iOS 18.0 using version 1.70.117

Case: New Users

example example example example example example
IMG_7346 IMG_7347 IMG_7348 IMG_7349 IMG_7350 IMG_7351

Case: Existing Users

example example example example
IMG_7354 IMG_7355 IMG_7356 IMG_7357
Uni-verse commented 2 weeks ago

Verified on iPad (7th Gen) running iOS 17.6 using version 1.70.117

Case: New Users

example example example example
IMG_1618 IMG_1619 IMG_1620 IMG_1621

Case: Existing Users

example example example
IMG_1622 IMG_1623 IMG_1624