brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.5k stars 2.26k forks source link

Copy change for prompt when downloading insecurely #36032

Open Uni-verse opened 6 months ago

Uni-verse commented 6 months ago

Description

Copy change for prompt when downloading insecurely

Message: File can't be downloaded securely Message body: (X KB) Action: Discard / Keep

Note: This is a new feature in C122

Steps to reproduce

  1. Enter http://www.pdf995.com/samples/pdf.pdf to URL bar or attempt to download file from insecure URL
  2. Observe prompt

QA Test Plan:

  1. Verify copy change (TBD)
  2. Confirm file is discarded when user selects Discard
  3. Confirm file is kept when user selects Keep
  4. Check fresh / upgraded profile.

Actual result

Screenshot 2024-02-13 at 4 32 07 PM

Expected result

Change copy for prompt above

Issue reproduces how often

Always

Version/Channel Information:

Device details

Brave version

1.64.69, Chromium 122.0.6261.29

timchilds commented 6 months ago

@rmcfadden3 how does this sound for the updated copy?

File can't be downloaded securely via https. File will be downloaded via http instead.
fmarier commented 6 months ago

I'd suggest something like:

File is not provided securely by the site via HTTPS. It can be downloaded using insecure HTTP.

rmcfadden3 commented 6 months ago

@fmarier — based on your version, it sounds like the thing to note here is that this is NOT a Brave failing. It's rather that the site itself isn't making the file available via HTTPS. If I'm reading that correctly, then I might slightly tweak your copy to:

Site is not providing the file for secure HTTPS download. Proceed with insecure HTTP download instead?

wdyt?

fmarier commented 6 months ago

@rmcfadden3 That's correct. The site is to blame for this.

Your version sounds good to me :+1:

anthonypkeane commented 6 months ago

Thanks @rmcfadden3

Can I make one small suggestion

{Site Name or URL] is not providing the file for secure HTTPS download. Proceed with insecure HTTP download instead? Cancel | Download

The URL only needs to be the domain name, i.e github.com

@fmarier does this sound okay? Thanks