search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Update l10n for 1.63.x (Chromium 122). #36084

Closed mkarolin closed 8 months ago

mkarolin commented 9 months ago

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

kjozwiak commented 8 months ago

Closing as https://github.com/brave/brave-core/pull/22179 was merged/uplifted into 1.63.x. The above requires 1.63.159 or higher for 1.63.x verification 👍

GeetaSarvadnya commented 8 months ago

Verification PASSED on

Brave | 1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit)
-- | --
Revision | 118f746822a0acc7abc8c48993a704fcd0e29122
OS | Windows 10 Version 22H2 (Build 19045.4046)

New strings

Manage V8 security

Germany France Kannada Hindi
image image image image

Automatic picture-in-picture

Germany France Kannada Hindi
image image image image

V8 optimizer content settings

Germany France Kannada Hindi
image image image image

Saved tab groups

Germany (str1) Germany (str2) France (str1) France (str2) Kannada (Str1) Kannada (Str2) Hindi (Str1) Hindi (Str2)
image image image image image image image image

Old strings

hffvld commented 8 months ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.159
Chromium: 122.0.6261.57 (Official Build) (64-bit)

ACTUAL RESULTS:

Russian Spanish French
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
German Japanese Arabic
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
wnilanka commented 8 months ago

@mkarolin @hffvld How to become a proofreader? We would like to review Sinhala translations.

image

Our account: https://app.transifex.com/user/profile/HelaBasa/ https://helabasa.yalu.lk/ HelaBasa is a translation & localization service in Sri Lanka. We have added Sinhala language to Firefox and Vivaldi browsers.

https://pontoon.mozilla.org/si/contributors/

Firefox browser (Desktop) firefox-desktop-2

Firefox browser (Mobile) firefox-mob

Vivaldi Browser (Chromium based) vivaldi-desktop-sinhala

mkarolin commented 8 months ago

cc: @AndyAnds265 ☝️

wnilanka commented 6 months ago

@mkarolin @AndyAnds265 Just a kind reminder in case you didn't have time to look into this issue.. (cc:@kjozwiak @hffvld)

AndyAnds265 commented 6 months ago

@wnilanka - thank you for this suggestion and offering to review the localization into Sinhala. We are in the process of changing to a new tooling system. Please let me look into this and I'll get back to you.

wnilanka commented 5 months ago

@AndyAnds265 Can you please tell me when we can use the new translation platform?

Our suggestions:

Cloud - Crowdin https://support.crowdin.com/features/ https://crowdin.com https://crowdin.com/enterprise https://crowdin.com/page/open-source-project-setup-request

On-Premise / Cloud - Weblate https://weblate.org/en/features/ https://weblate.org/en/download/ https://docs.weblate.org/en/latest/admin/install.html

wnilanka commented 4 months ago

@AndyAnds265 Would you kindly give me an update from your side?

AndyAnds265 commented 3 months ago

@wnilanka, thank you for your continued interest. We are unable to add Sinhala at this time. I would love for us to support the language in the future, but we are limited on our focus markets right now. As soon as we are focusing on the region and expanding our languages there I will let you know.

wnilanka commented 3 months ago

@AndyAnds265 I read this discussion and saw the temporally solution for Bosnian language. According to the public details, you have paid for Croatian and Serbian translations.

Please see the statistics below. If you don't see a benefit and don't want to support, we will have to pause our contribution and focus on other products.

https://en.wikipedia.org/wiki/Sinhala_language

Translation status: image

Comparison:

Sinhala language speakers - L1: 16M., L2: 2M. (wikipedia), L1: 16M., L2: 3M. (omniglot), 14.9M. (unicode) Serbian language speakers - c. 12M. (wikipedia), c. 9-10M. (omniglot), 7.6M. (unicode) Croatian language speakers - L1: 5.1M., L2: 1.3M. (wikipedia), c. 6.7M. (omniglot), 5.7M. (unicode) Bosnian language speakers - 2.6M. (wikipedia), 2.2M. (omniglot), 3.8M. (unicode) Montenegrin language speakers - 232,600 (wikipedia), 230,000 (omniglot), — (unicode) (M. - million, c. - circa)

Official Chrome app - Sinhala

https://github.com/user-attachments/assets/6a37e4f5-14de-4572-9946-76f25ea43cad

AndyAnds265 commented 3 months ago

@wnilanka, hey and thank you for your patience.

It is possible that I misunderstood what you were asking for originally.

Can you confirm that you are just trying to review the content that you have already localized? When I search Sinhala strings in Transifex, I can see that HelaBasa worked on them before. I assume this was through a pro-bono contribution.

Is your team just trying to continue that so we can publish the language? If so, I am able to work on that with you.

wnilanka commented 3 months ago

Is your team just trying to continue that so we can publish the language?

Yes. 😊

AndyAnds265 commented 3 months ago

Can you check if you have access now?

wnilanka commented 3 months ago

Can you check if you have access now?

👍

wnilanka commented 3 months ago

brave

@AndyAnds265 @mkarolin Can you please enable this checkbox component? We want to test our translations. Note: We can download the latest translations from transifex and follow these instructions to build.

mkarolin commented 3 months ago

The language is disabled for UI in Chromium (https://issues.chromium.org/issues/40073213). No clear indication as to why, but from what I recall they typically disable languages that don't have full support in V8 (something to do with dates or numbers formatting). It's probably worth opening a separate issue for getting the language enabled in Brave.

wnilanka commented 3 months ago

It's probably worth opening a separate issue for getting the language enabled in Brave.

https://github.com/brave/brave-browser/issues/40232

The language is disabled for UI in Chromium. No clear indication as to why

https://issues.chromium.org/issues/41287742#comment40 me...@chromium.org There are currently no plans to add it due to binary size constraints. That may be revisited by the Desktop team in the future.

Binary size constraints - Binary size increases are what's blocking Desktop Chrome from adding more languages. Each language is approximately 250kb, and any binary size increase causes a drop in updates.