srirambv
commented
5 years ago Might be conflicting with behaviour on #1097
Open kjozwiak opened 5 years ago
srirambv
commented
5 years ago Might be conflicting with behaviour on #1097
rebron
commented
5 years ago If we get any +1s on this let's revisit.
bsclifton
commented
5 years ago Per comment by @rebron - at the moment, we have no plans to change this... +1's with desired behavior are welcome, otherwise we can move to a wontfix
When the URL bar is in "edit" mode (you typed into it), the buttons should be hidden, IMO. The reason being: if the buttons DID show- what URL would it correspond to? (the one being edited? or the one you're currently on). Changing this could cause some complexities. The buttons are restored if you hit enter or escape
Description
When you paste or type something into the omnibox/URL bar, the Rewards/Shield icons will disappear which is expected as the drop down from the omnibox/URL will appear. However, if you click away from the omnibox/URL bar and continue browsing, the text will stay in the omnibox/URL and the Rewards/Shield icons will stay hidden.
Note: This is also reproducible in Chrome so not sure if it's worth fixing. But it's affecting us worse due to having the Shield/BR icon in the URL area.
Steps to Reproduce
You'll notice that you typed is left behind in the URL and both Rewards/Shield icons are not visible.
Actual result:
Expected result:
If someone moves away from the URL, we should probably revert to the current URL so the Rewards/Shield icons are being displayed again.
Reproduces how often:
100% using the above STR.
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Does the issue resolve itself when disabling Brave Shields? No
Is the issue reproducible on the latest version of Chrome? This is also reproducible in Chrome so not sure if it's worth fixing. But it's affecting us worse due to having the Shield/BR icon in the URL area.
Additional Information
CCing @brave/legacy_qa