[Leo] `Your Brave account session has expired...` message is shown when a Premium subscription purchased on Android and Brave reinstalled

hffvld commented 8 months ago

Description

Your Brave account session has expired... message is shown when a Premium subscription is purchased on Android and Brave reinstalled.

Steps to reproduce

Launch Brave
Open Leo UI
Three-dot menu > Go Premium > Upgrade now
Purchase Leo Premium Subscription
Delete and reinstall Brave
Launch Brave > Go through onboarding
Open Leo UI > Type a query
Tap I understand > Observe Your Brave account session has expired... message
Tap Refresh > Observe account.brave.com is opened

Actual result

Your Brave account session has expired... message is shown when a Premium subscription is purchased on Android and Brave reinstalled.

1

https://github.com/brave/brave-browser/assets/128532965/885b8c27-59a9-448d-b395-deaaaa88f5bd

Expected result

The message Your Brave account session has expired... must be removed when the subscription is purchased via Google Play Store.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? YES
Can you reproduce this issue with the current Play Store Beta version? YES
Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): ANY
Android version: ANY

Brave version

Brave build: 1.63.156
Chromium: 122.0.6261.43 (Official Build) (64-bit)

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

cc @SergeyZhukovsky @Uni-verse

SergeyZhukovsky commented 7 months ago

that should be fixed when multi device support on back end lands.

mattmcalister commented 7 months ago

@SergeyZhukovsky if the user pays via Play Store, deletes Brave, reinstalls Brave, and tries to re-activate their account via account.brave.com, will they still be able to pass the purchase receipt and connect their account? or will they have to Restore the purchase on their device first? and in that case this is irrelevant.

SergeyZhukovsky commented 7 months ago

@SergeyZhukovsky if the user pays via Play Store, deletes Brave, reinstalls Brave, and tries to re-activate their account via account.brave.com, will they still be able to pass the purchase receipt and connect their account? or will they have to Restore the purchase on their device first? and in that case this is irrelevant.

@mattmcalister they shouldn't go to the account.brave.com. Brave auto fetches the subscription from Play Store and knows that it's been purchased. We don't show the Refresh banner if the subscription is from Play Store(that's been merged last week https://github.com/brave/brave-core/pull/22149). But it still won't fetch the premium credentials as multi device support has to be implemented, @evq mentioned that it's planned for the release. So the users will continue to use their Play Store subscription automatically in that case when we have the multi device support.

brave / brave-browser