brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.22k forks source link

Option to have Vertical Tabs "Expand/Minimize Tabs" toggle button apply only to current window instead of all Brave windows #36224

Open richardso21 opened 4 months ago

richardso21 commented 4 months ago

Description

I usually have 5+ Brave browser windows, each with ~10 tabs, open concurrently for my workflow. Coming back from Arc (with a similar workflow), I missed how I was able to minimize the vertical tab strip for certain windows, while my other windows would retain the expanded strip. This would be useful if I'm watching something or playing a game in one window and would like to use more screen space without going full screen (fullscreen on macos 🤮), while keeping the rest of my windows and their vertical tab strips the way they are.

It turns out that this also makes the expanding/minimizing animation lag significantly (probably because it is applying the change to all the other windows' strips in the background).

I believe having an option in the settings pane to have the toggle button be applied to only the current window instead of globally would be nice to have. This change would also be reflected on the keyboard shortcut, or we can have a separate keyboard shortcut that applies the strip expand/minimize globally. Thank you!

Steps to Reproduce

  1. Enable Vertical tabs
  2. Have multiple brave windows open
  3. Toggle Expand/Minimize Tabs at top left of the vertical tab strip
  4. See that all other Brave windows were affected as well

Actual result:

Screen Recording 2024-02-20 at 10 29 38 AM This is recorded with these 2 windows + another 5 windows running in the background, so about 52 total tabs. There is a noticeable delay between clicking the strip expand/minimize toggle button and the actual change being reflected to the window I am focused on. Realize the window that I don't have focused have the same delay and change.

Expected result:

Screen Recording 2024-02-20 at 10 37 47 AM This is recorded when only one window and tab of brave is open. This is what the expanding/minimizing animation should look like.

Reproduces how often:

N/A

Brave version (brave://version info)

1.62.165 Chromium: 121.0.6167.184 (Official Build) (arm64)

Version/Channel Information:

rebron commented 4 months ago

@sangwoo108 What do you think on vertical tab strip by Window?

rebron commented 4 months ago

Hi @richardso21. Thanks for filing the issue. In general, are you liking our sidebar implementation better or are there other things you'd like to see?

richardso21 commented 4 months ago

So far, my experience with the vertical tab strip has been solid, nothing else to complain about so far, though I think this change will make it just perfect for me!

robalexj commented 3 months ago

I would also like this feature. I normally have a second Brave window open on my smaller laptop screen; on this I'd like to minimise the tab strip (because the screen size is small), whereas on my main monitor I want it expanded (plenty of space there). I also generally only have one tab open on my smaller laptop screen, making the tab strip redundant.

sangwoo108 commented 3 months ago

@sangwoo108 What do you think on vertical tab strip by Window?

Sorry, somehow I missed this. Vertical tab strip expanded per window makes sense to me because I have two different sized display - one is small and the other is large. So when I expand the vtab for large screen, a window in small display is really hard to use, as page area gets too narrow.

Psionyde commented 1 week ago

Bump for this.

I regularly work with.. too many.. windows and tabs open and it is very annoying and frustrating not being able to shrink/hide the vtab bar per-window, both in the missing functionality (which would be very useful for single-purpose-single-tab windows) and the chonky lag when toggling globally.

My ideal scenario would be configurable default behaviour via either vtab settings or ://flags, with a per-window override modifier (perhaps ctrl-click and/or rclick).

Apart from that, wholly positive experience with the vtab implementation. Absolute gamechanger. 9/10 👌

(PS- maybe also a modifier click to swap vtab display side for current window?)

(PPS- any chance of an open tab+window count in the tabsearch "Open tabs" header? I really don't want to know. But also I do.)