brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.35k forks source link

Upgrade from Chromium 122.0.6261.43 to Chromium 122.0.6261.57 #36242

Closed emerick closed 9 months ago

emerick commented 9 months ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/122.0.6261.43..122.0.6261.57?pretty=fuller&n=10000

QA tests:

Additional checks:

kjozwiak commented 9 months ago

Quick overview of the work remaining re: affected areas due to C122 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/35200#issue-2072494839:

Platforms that still need to check/verify the affected areas due to C122 changes as per https://github.com/brave/brave-browser/issues/35200#issue-2072494839:

GeetaSarvadnya commented 9 months ago

Verification PASSED on

Brave | 1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit)
-- | --
Revision | 118f746822a0acc7abc8c48993a704fcd0e29122
OS | Windows 10 Version 22H2 (Build 19045.4046)

image

LaurenWags commented 9 months ago

Verified with

Brave | 1.63.159 Chromium: 122.0.6261.57 (Official Build) (x86_64)
-- | --
Revision | 118f746822a0acc7abc8c48993a704fcd0e29122
OS | macOS Version 13.6.4 (Build 22G513)
Screenshot 2024-02-21 at 8 51 16 AM
MadhaviSeelam commented 9 months ago

Verification PASSED using

Brave   1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit) 
Revision    118f746822a0acc7abc8c48993a704fcd0e29122
OS  Linux
Verify that permission request bubble works as expected - PASSED Generally: - spot checked a couple permission types - spot checked allow/block - spot checked several permission lifetime values - spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content - used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED - Visited browserleaks.com/geo - Confirmed location permission prompt displayed as expected - Kept default selection of "Until I close this site" and selected "Block" - Confirmed permission shows as denied via tune icon in URL bar - Confirmed expected behavior on brave://settings/content/location Example | Example | Example | Example --- | --- | --- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/f12eb8b5-ad02-466b-8ddf-3ec391a376c8)|![image](https://github.com/brave/brave-browser/assets/98358127/e635a952-2d89-4b95-a6b3-c721e5ed2621)|![image](https://github.com/brave/brave-browser/assets/98358127/d80afe52-6cb3-4c18-b1a0-8ed50a74b1d6)|![image](https://github.com/brave/brave-browser/assets/98358127/c23add59-111a-49b2-adbb-5ca4f7206967) - Closed the site - Waited at least 30s and looked at brave://settings/content/location - Confirmed site was no longer listed - Reopened site - Confirmed re-prompted for permission Example | Example --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/4bbdeb1b-33d9-4c08-89db-30c552eeb8bf)|![image](https://github.com/brave/brave-browser/assets/98358127/b93364da-5abd-426e-b4cb-6288960b0938) - Changed permission lifetime value to "1 week" and selected "Allow" - Confirmed permission shows as allowed via tune icon in URL bar - Confirmed expected behavior on brave://settings/content/location Example | Example | Example | Example --- | --- | --- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/8a205156-3f2a-4296-b4d3-7f332db7cf86)|![image](https://github.com/brave/brave-browser/assets/98358127/c4e3e56d-5bb2-4147-8ebb-d32120ab464e)|![image](https://github.com/brave/brave-browser/assets/98358127/176bfed3-7cc2-4fee-929a-689f2fad7a19)|![image](https://github.com/brave/brave-browser/assets/98358127/d6a556c4-f1fc-4b2d-b6a5-9a56538025a3) - Closed the site - Waited at least 30s and looked at brave://settings/content/location - Confirmed site was still listed as "allowed" - Reopened site - Confirmed not prompted for permission - Closed site, closed browser - Advanced computer clock a few days (~3) - Reopened browser - Confirmed site was still listed as "allowed" on brave://settings/content/location - Visited site and confirmed not prompted for permission - Closed site, closed browser Example | Example | Example | Example --- | --- | --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/4137cd1e-2e1e-4776-9ff5-890ffc1ddb39)|![image](https://github.com/brave/brave-browser/assets/98358127/4f819a7d-e718-4ede-89b1-8f45e64ad8d9)|![image](https://github.com/brave/brave-browser/assets/98358127/3045f495-2882-4d49-9f9e-e70330de923c)|![image](https://github.com/brave/brave-browser/assets/98358127/1583c336-02ce-4b4d-b276-732f3d104d1b) - Advanced computer clock (~8 days from the day the permission was set) - Reopened browser - Visited brave://settings/content/location - Confirmed site was no longer listed on this page - Visited site and confirmed prompted for permission Example | Example --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/3159cfb0-45b0-4722-94a7-83b35080debf)|![image](https://github.com/brave/brave-browser/assets/98358127/2a71bea4-137e-4bba-8151-84818a53f3a6)
2. Notifications - PASSED - Visited permission.site, selected "Notifications" button - Confirmed notification permission prompt displayed as expected - Kept default selection of "Until I close this site" and selected "Allow" - Confirmed permission shows as allowed via tune icon in URL bar - Confirmed expected behavior on brave://settings/content/notifications Example | Example | Example | Example --- | --- | --- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/f10df9d6-c6b9-4d84-82ed-b80d11f9f97c)|![image](https://github.com/brave/brave-browser/assets/98358127/f3bc71d5-e984-48c8-abfc-8e7e4633322d)|![image](https://github.com/brave/brave-browser/assets/98358127/2fc7a014-ad97-4371-ae46-d166c6a4a6ea)|![image](https://github.com/brave/brave-browser/assets/98358127/890632a8-384e-4673-9ece-6cf03dc99bec) - Closed the site - Waited at least 30s and looked at brave://settings/content/notifications - Confirmed site was no longer listed - Reopened site, selected "Notifications" button - Confirmed re-prompted for permission Example | Example --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/66ff3616-10c0-4389-81bb-7ee99cbcfc1a)|![image](https://github.com/brave/brave-browser/assets/98358127/fd3eed46-22fa-4160-81e4-8d37384bbe5f) - Changed permission lifetime value to "24 hours" and selected "Block" - Confirmed permission shows as denied via tune icon in URL bar - Confirmed expected behavior on brave://settings/content/notifications Example | Example | Example | Example --- | --- | --- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/24e5f3f7-84aa-424d-8984-2a8dc8b58685)|![image](https://github.com/brave/brave-browser/assets/98358127/19e02af0-483d-46ad-9eba-fe6e74355e9e)|![image](https://github.com/brave/brave-browser/assets/98358127/bc3c3219-b3e6-490d-beb0-e6181ba23c51)|![image](https://github.com/brave/brave-browser/assets/98358127/c01e306f-c484-44a0-b4a8-35c76969be23) - Closed the site - Waited at least 30s and looked at brave://settings/content/notifications - Confirmed site was still listed as "not allowed" - Reopened site, clicked on "Notifications" button - Confirmed not prompted for permission - Closed site, closed browser - Advanced computer clock 23 hrs - Reopened browser - Confirmed site was still listed as "denied" on brave://settings/content/notifications - Visited site, clicked "Notifications" button and confirmed not prompted for permission - Closed site, closed browser Example | Example | Example | Example | Example --- | --- | --- | ---- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/2ba60910-89ef-42a3-a3c9-61be59c7e1ed)|![image](https://github.com/brave/brave-browser/assets/98358127/53635c1c-fce7-4a87-b728-30e8546ee0ac)|![image](https://github.com/brave/brave-browser/assets/98358127/a4d2ad39-9573-4f16-ae76-08fd666571d6)|![image](https://github.com/brave/brave-browser/assets/98358127/86fbb717-cea9-4d48-bdb9-f160b5f2523a)|![image](https://github.com/brave/brave-browser/assets/98358127/8e289245-96d7-433e-800f-fbf6cef11bb5) - Advanced computer clock (25 hours from the time when the permission was set) - Reopened browser - Visited brave://settings/content/notifications - Confirmed site was no longer listed on this page - Visited site, clicked "Notifications" button and confirmed prompted for permission Example | Example --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/e5d48b18-435f-486c-8e6d-f34bc46fc7de)|![image](https://github.com/brave/brave-browser/assets/98358127/ccb0f356-55e8-4fc9-88c3-be21787c0e9b)
Verify that omnibox works as expected - PASSED - Confirmed that info bar color looks as expected in light theme - Confirmed that info bar color looks as expected in Dark theme - Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected - Confirmed that the icons in the URL bar works as expected Light theme | Dark theme | Suggestions --------------|--------------|-------------- ![image](https://github.com/brave/brave-browser/assets/98358127/6f1f5e26-6aab-4419-97fb-8b25b6cf8e22)|![image](https://github.com/brave/brave-browser/assets/98358127/c92f2f2a-fa3f-4839-9202-9ea6366b6017)|![image](https://github.com/brave/brave-browser/assets/98358127/55abcb82-5972-44c3-93c9-67f624a5aded)
Verify that syncing works as expected - PASSED - Verified the sync functionality in general it works fine without any issues - When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices - Confirmed the bookmarks synced across all the devices in a sync chain - Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain - When 2 devices are in a sync chain, remove a device resets the sync chain - Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Verify that content settings work as expected - PASSED **_Autoplay_** - Confirmed that the content settings are working as expected - Open a `Youtube.com` and click on the lock icon and navigate to `Site settings`, look for the `Autoplay` settings, by default it's set to "Allow (Default)", open any video in youtube.com and ensured that the video is autoplayed. - Set `Autoplay` settings to "Block" for youtube.com and reload the youtube.com and open any video and ensured that the video is NOT autoplayed. - Confirmed that `Autoplay was blocked on this page` icon is displayed in the URL bar Example | Example | Example | Example ----------|-----------|----------|---------- ![image](https://github.com/brave/brave-browser/assets/98358127/6c193c8d-6bc3-443d-8e24-c482bfeda209)|![image](https://github.com/brave/brave-browser/assets/98358127/8bb3cec1-45b9-42b1-a065-bcacfdb5a6a0)|![image](https://github.com/brave/brave-browser/assets/98358127/68be5592-f1be-4826-abc7-da9fb5bbbb7a)|![image](https://github.com/brave/brave-browser/assets/98358127/6fa67cb8-20ff-4a8f-8139-82a12d696979) **_Block script_** - Confirmed that Block scripts content settings works as expected - Open Twitter.com and click on the lock icon and navigate to `Site settings` and confirm that the `Java scripts` content settings is set to default "Allow(default)" - Set the Java scripts content settings to "Block" for Twitter and reload the twitter.com and ensured that the java scripts are blocked on this page and page doesn't load - Open the shields settings and ensured that the `Scripts` (`JavaScript`) is blocked via `Shields` Example | Example | Example | Example | Example | Example | Example ----------|-----------|----------|-----------|---------|----------|----- ![image](https://github.com/brave/brave-browser/assets/98358127/918f3459-e9c8-48c5-bddd-36fe30db29a0)|![image](https://github.com/brave/brave-browser/assets/98358127/7c254387-94fb-43e6-a930-a59d924c3106)|![image](https://github.com/brave/brave-browser/assets/98358127/8ba3ae5d-c5df-4907-920d-2e6232a6dfe2)|![image](https://github.com/brave/brave-browser/assets/98358127/905a3c74-1a20-45fb-8da4-2a0c120375b8)|![image](https://github.com/brave/brave-browser/assets/98358127/cd8667e1-08f5-457b-9631-22730d5fd7b8)|![image](https://github.com/brave/brave-browser/assets/98358127/509becbd-2be5-4f30-88c4-824425d2c19c)|![image](https://github.com/brave/brave-browser/assets/98358127/7fa04e46-5d52-405e-b4e4-2e93b44e3fa5)
Verify cookie settings/behavior - PASSED **_Update the cookies setting_** 1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A 2. Go to brave://settings/cookies and select `Allow 3rd party cookies` 3. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is `some value` 4. Go to global shield settings and ensure that the cookies setting is set to `Disabled` due to step 2 Case 1: 1. Clean profile `1.64.x - CR 122` 2. Open a site 3. Click on the site shield settings 5. Change the trackers and ad blocking settings from `Block cross site cookies` to `Block all cookies` 6. Restart the browser 7. Open the site shield settings, confirmed updated cookies settings are reatined example | example | example ----- | ---- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/b153b23b-6f9c-4027-b763-b34a2921b369)|![image](https://github.com/brave/brave-browser/assets/98358127/bc05a1da-f87c-4c6f-a1fb-dad69912fd0a)|![image](https://github.com/brave/brave-browser/assets/98358127/445e5dd5-8fc0-45c3-9f75-ea6e3f327471) Case 2: 1. Continuation of case 1 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are reatined example | example | example ---- | ----- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/86b47b61-b33d-4eea-9e39-898c08c174a7)|![image](https://github.com/brave/brave-browser/assets/98358127/0881bf82-53c7-416c-a646-60dc45bc3398)|![image](https://github.com/brave/brave-browser/assets/98358127/48f108eb-3a4e-44e3-b1c1-f9936f909703) Case 3: 1. Continuation of case 2 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Allow all cookies` to `Block cross site cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are reatined example | example | example ----- | ----- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/8e9c9be6-d005-4d6e-af7e-517d492cf484)|![image](https://github.com/brave/brave-browser/assets/98358127/cd7f42f8-adeb-48e4-ad24-bcdf18a88c0a)|![image](https://github.com/brave/brave-browser/assets/98358127/2f0cadf1-0809-4cf9-8c17-f5ca799eda09)
stephendonner commented 9 months ago

Verification PASSED using

Brave   1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit) 
Revision    118f746822a0acc7abc8c48993a704fcd0e29122
OS  Linux
Verify Speedreader works as expected - PASSED 1. installed `1.63.159` 2. launched Brave 3. loaded `https://www.vox.com/2024/2/21/24078362/inflation-car-insurance-distracted-driving-costs` 4. clicked on the `Turn on Speedreader` icon in the URL bar 5. confirmed the article rendered in Speedreader mode 6. confirmed ability to customize font, background colors, etc. 7. confirmed ability to toggle `Leo` sidebar panel via Speedreader `Leo` button (NOTE: cut out text-to-speech section here since it's not-yet supported on `linux.`I enabled it via a feature flag on startup, but it lacked any `voice`s.) example | example | example | example | example | example ---------|---------|----------|----------|---------|--------- Screen Shot 2024-02-21 at 1 01 04 PM | Screen Shot 2024-02-21 at 1 01 07 PM | Screen Shot 2024-02-21 at 1 07 09 PM | Screen Shot 2024-02-21 at 1 07 11 PM | Screen Shot 2024-02-21 at 1 07 19 PM | Screen Shot 2024-02-21 at 1 07 22 PM
Verify PDF content extraction (AI feature) works as expected - PASSED **Verify PDF compatible with Free modal** - `PASSED` 1. installed `1.63.159` 2. launched Brave 3. clicked on `Leo` in the sidebar 4. loaded and opened `https://arxiv.org/pdf/2401.01353.pdf` 5. clicked `Summarize this page` 6. confirmed that page PDF content is summarized correctly 7. clicked on `Suggest questions` 8. confirmed that suggested questions are also relevant to PDF content Example | Example | Example | Example | Example ----------|-----------|---------|-----------|------------ Screen Shot 2024-02-21 at 1 37 07 PM | Screen Shot 2024-02-21 at 1 37 26 PM | Screen Shot 2024-02-21 at 1 38 01 PM | Screen Shot 2024-02-21 at 1 38 12 PM | Screen Shot 2024-02-21 at 1 38 31 PM | Screen Shot 2024-02-21 at 1 38 48 PM **Verify PDF compatible with Premium modal** - `PASSED` 1. installed `1.63.159` 2. launched Brave using `----env-leo=staging --env-ai-chat.bsg.dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr --v=2` 3. clicked on `Leo` in the sidebar 4. logged into my `Premium` account using `account.bravesoftware.com` 5. clicked `Refresh Leo` 6. confirmed I had `Premium`-badging/credentials 7. loaded and opened `https://arxiv.org/pdf/2401.01353.pdf` 8. clicked `Summarize this page` 9. confirmed page PDF content is summarized correctly 10. clicked on `Suggest questions` 11. confirmed suggested questions are relevant to PDF content Example | Example | Example | Example | Example ----------|-----------|---------|-----------|----------- Screen Shot 2024-02-21 at 1 21 24 PM | Screen Shot 2024-02-21 at 1 21 38 PM | Screen Shot 2024-02-21 at 1 21 55 PM | Screen Shot 2024-02-21 at 1 22 09 PM | Screen Shot 2024-02-21 at 1 22 31 PM

Settings comparison - PASSED

- A new settings `Manage V8 security` is added under brave://settings/security page as part of CR122. As per the slack conversion https://bravesoftware.slack.com/archives/C7VLGSR55/p1707784332486479?thread_ts=1707520964.163159&cid=C7VLGSR55, we are going to retain this settings in Brave. - Click on the setting `Manage V8 security` redirects to V8 optimizer page Example | Example ----------|---------- Screen Shot 2024-02-21 at 1 42 34 PM | Screen Shot 2024-02-21 at 1 42 51 PM - `Quick commands` settings is added as part of Brave under `hamburger menu>More tools>Quick commands`, confirmed that all the commands are working as expected example | example | example | example ---------|----------|---------|--------- Screen Shot 2024-02-21 at 1 49 08 PM | Screen Shot 2024-02-21 at 1 49 22 PM | Screen Shot 2024-02-21 at 1 49 42 PM | Screen Shot 2024-02-21 at 1 49 44 PM - A new content setting `Automatic picture-in-picture` is added as part of CR122 example | example ---------|--------- Screen Shot 2024-02-21 at 1 53 15 PM | Screen Shot 2024-02-21 at 1 53 20 PM - A new `Saved tab groups` sync data added as part of CR122 (not sure whether we want to retain this or not, slack discussion https://bravesoftware.slack.com/archives/C7VLGSR55/p1707919993569269?thread_ts=1707520964.163159&cid=C7VLGSR55 Screen Shot 2024-02-21 at 1 55 29 PM

Brave startup calls - PASSED

hffvld commented 9 months ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.159
Chromium: 122.0.6261.57 (Official Build) (64-bit) 

1 2
1 2
hffvld commented 9 months ago

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.63.159
Chromium: 122.0.6261.57 (Official Build) (64-bit) 

1 2
1 2