Disable Remove All button when there are no entries for connected Dapps - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

16.98k stars 2.21k forks source link

Disable Remove All button when there are no entries for connected Dapps #36430

Open srirambv opened 4 months ago

srirambv commented 4 months ago

Description:

Disable Remove All button when there are no entries for connected Dapps

Steps to Reproduce

Create a new wallet on 1.63
Go to Accounts settings and select Security
Remove All button is enabled
Click the button, shows confirmation message to remove 0 websites

Actual result:

Expected result:

Disable Remove All button when there are no linked Dapps

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

Can you reproduce this issue with the most recent build from TestFlight? Yes
Can you reproduce this issue with the previous version of the current build from TestFlight? NA
Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 13 (iOS 17.6) & iPhone 7+ (iOS 16.8.1)

Website problems only:

Does the issue resolve itself when disabling Brave Shields?NA
Is the issue reproducible on the latest version of Mobile Safari? NA

Additional Information

cc: @StephenHeaps @nuo-xu

StephenHeaps commented 4 months ago

This one doesn't seem to reproduce every time which is odd, even after adding connection and removing it. I can't currently reproduce it on device or simulator on iOS 16/17 (iPhone 13 (iOS 17.6) & iPhone 7+ (iOS 16.8.1) mentioned as reproduced in issue).

https://github.com/brave/brave-browser/assets/5314553/4d8adc59-c9bb-4ff9-b509-e6cb383ed83f

https://github.com/brave/brave-browser/assets/5314553/35168c49-195c-4a1a-96f7-995aeea069a8

The current code is specifically disabling this already, too: https://github.com/brave/brave-core/blob/master/ios/brave-ios/Sources/BraveWallet/Settings/DappsSettings.swift#L166