search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.77k stars 2.32k forks source link

Test failure: WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService #36722

Closed brave-builds closed 7 months ago

brave-builds commented 7 months ago

Greetings human!

Bad news. WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService failed on macos x64 beta v1.64.102.

Stack trace ``` [ RUN ] WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService [61135:259:0312/005510.279211:WARNING:chrome_main_delegate.cc(742)] This is Chrome version 122.1.64.102 (not a warning) [61135:259:0312/005510.373696:ERROR:policy_logger.cc(157)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(161) Cloud management controller initialization aborted as CBCM is not enabled. Please use the `--enable-chrome-browser-cloud-management` command line flag to enable it if you are not using the official Google Chrome build. [61135:259:0312/005510.411251:WARNING:external_provider_impl.cc(514)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl. Key external_update_url has value "", which is not a valid URL. [61135:71171:0312/005510.427932:INFO:brave_referrals_service.cc(78)] Could not get promo code from /Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-beta/src/out/Release. The extended attribute com.brave.refcode was not found. ../../brave/browser/ui/views/toolbar/wallet_button_notification_source_browsertest.cc:381: Failure Value of: success Actual: false Expected: true Stack trace: 0 brave_browser_tests 0x00000001053930bb brave_browser_tests + 6574267 1 brave_browser_tests 0x000000010998beda brave_browser_tests + 79945434 2 brave_browser_tests 0x000000010998c37d brave_browser_tests + 79946621 3 brave_browser_tests 0x0000000109992d6a brave_browser_tests + 79973738 4 brave_browser_tests 0x0000000109992a08 brave_browser_tests + 79972872 5 brave_browser_tests 0x0000000105391a05 brave_browser_tests + 6568453 6 brave_browser_tests 0x000000010f93495c secp256k1_ecdsa_recover + 5815948 7 brave_browser_tests 0x0000000107dd5091 brave_browser_tests + 50884753 8 brave_browser_tests 0x0000000107dd6aa2 brave_browser_tests + 50891426 9 brave_browser_tests 0x0000000107dd252c brave_browser_tests + 50873644 10 brave_browser_tests 0x00000001091b20b0 brave_browser_tests + 71712944 11 brave_browser_tests 0x00000001091b3439 brave_browser_tests + 71717945 12 brave_browser_tests 0x00000001091b3067 brave_browser_tests + 71716967 13 brave_browser_tests 0x00000001091b17d7 brave_browser_tests + 71710679 14 brave_browser_tests 0x00000001091b19c5 brave_browser_tests + 71711173 15 brave_browser_tests 0x000000010f933e6c secp256k1_ecdsa_recover + 5813148 ../../brave/browser/ui/views/toolbar/wallet_button_notification_source_browsertest.cc:405: Failure Expected equality of these values: 1u Which is: 1 count_result.value() Which is: 0 Stack trace: 0 brave_browser_tests 0x0000000105391ddd brave_browser_tests + 6569437 1 brave_browser_tests 0x000000010f93495c secp256k1_ecdsa_recover + 5815948 2 brave_browser_tests 0x0000000107dd5091 brave_browser_tests + 50884753 3 brave_browser_tests 0x0000000107dd6aa2 brave_browser_tests + 50891426 4 brave_browser_tests 0x0000000107dd252c brave_browser_tests + 50873644 5 brave_browser_tests 0x00000001091b20b0 brave_browser_tests + 71712944 6 brave_browser_tests 0x00000001091b3439 brave_browser_tests + 71717945 7 brave_browser_tests 0x00000001091b3067 brave_browser_tests + 71716967 8 brave_browser_tests 0x00000001091b17d7 brave_browser_tests + 71710679 9 brave_browser_tests 0x00000001091b19c5 brave_browser_tests + 71711173 10 brave_browser_tests 0x000000010f933e6c secp256k1_ecdsa_recover + 5813148 [61140:14595:0312/005512.597447:WARNING:sqlite_persistent_store_backend_base.cc(197)] Failed to post task from LoadNelPoliciesAndNotifyInBackground@net/extras/sqlite/sqlite_persistent_reporting_and_nel_store.cc:1324 to client_task_runner_. [ FAILED ] WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService, where TypeParam = and GetParam() = (2379 ms) [ FAILED ] WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService ```
Previous issues * #36351 [Find all](https://github.com/brave/brave-browser/issues?q=type%3Aissue+label%3Abot%2Ftype%2Ftest+in%3Atitle+%22Test+failure%3A+WalletButtonNotificationSourceTest.CounterReset_WhenResetTxService%22)
yrliou commented 7 months ago

This is fixed on master via https://github.com/brave/brave-core/pull/22430, just needs an uplift.

kjozwiak commented 7 months ago

Closing the above and also adding into https://github.com/brave/brave-core/pull/22430#issue-2164169954 👍 It's listed in both https://github.com/brave/brave-core/pull/22551 & https://github.com/brave/brave-core/pull/22552 so it will get automatically moved into the appropriate milestones once those PRs are merged.