brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.85k stars 2.33k forks source link

[Small screen issue]: NTP SI logo not displayed properly on small window size #36730

Open LaurenWags opened 8 months ago

LaurenWags commented 8 months ago

Description

When new tab has a sponsored image, the logo doesn't display fully on small window sizes.

Only making my browser full screen (fn+f) will show NTP SI logo as expected.

Steps to Reproduce

  1. Grabbed latest release from brave.com
  2. Launched a fresh profile on a laptop (2020 13 in macOS M1)
  3. Opened new tabs until I got a sponsored image

Actual result:

This is the default window size on a new profile - the logo is cut off on the lower left corner.

Screenshot 2024-03-12 at 2 55 05 PM

Even if I make my window bigger (not full screen, just taller and wider), the NTP still doesn't respond appropriately:

Screenshot 2024-03-12 at 3 00 30 PM

Expected result:

NTP should handle the small window size and show the logo appropriately. This is how NTP SI looks when browser is full screen (fn+f):

Screenshot 2024-03-12 at 3 03 35 PM

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron @brave/qa-team

MadhaviSeelam commented 2 months ago

NTP SI logo is shown as expected on 14" windows laptop with following resolution. However, the text seems to overlap with News cards and Search widget.

image

Brave | 1.70.92 Chromium: 128.0.6613.85 (Official Build) beta (64-bit)
-- | --
Revision | 711f50838f629ac2be4d1d9592f72adecfd3c928
OS | Windows 11 Version 23H2 (Build 22631.4037)
2024-08-27_12h37_58