brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

`Contribution banner` doesn't show the picture on the top of the screen #36737

Open hffvld opened 8 months ago

hffvld commented 8 months ago

Description

The Tipping banner doesn't show the picture on the top of the screen.

Steps to reproduce

  1. Launch Brave 1.61.x or newer
  2. Enable Rewards (Staging is fine) > Connect custodian
  3. Go to https://wikipedia.org or https://github.com/miyayes
  4. Tap Rewards thumbnail > Send contribution > Observe

Actual result

The Tipping banner doesn't show the picture on the top of the screen. This is a regression issue, and starts happening with build 1.61.x.

1 2 3
1 2 3
1 2 3

https://github.com/brave/brave-browser/assets/128532965/13388348-8e3c-48c2-ac2f-ea80a18bd826

Expected result

The picture on the tipping banner must be shown.

1 2 3
1 2 3
1 2 3

Issue reproduces how often

Easily reproduced

Version/Channel Information:

Device details

Brave version

Brave build: 1.65.73 
Chromium: 123.0.6312.29 (Official Build) canary (64-bit) 

Website problems only

Additional information

Miyayes commented 7 months ago

Once this is done, check this issue again. Fix is server-side: https://github.com/brave-intl/creators-private-issues/issues/1796

deeppandya commented 7 months ago

@Miyayes is it possible to get the access to check : https://github.com/brave-intl/creators-private-issues/issues/1796?

eldk commented 1 week ago

Hello,

I think this is related and you have seen those links :

Can't upload customized creator banner and logo (png or jpg) from Brave creator contribution page customisation interface https://publishers.basicattentiontoken.org/en/publishers/contribution_page

https://community.brave.com/t/brave-creators-contributions-page-building-seems-to-be-ko/567735/4 https://community.brave.com/t/brave-creators-contributions-page-building-seems-to-be-ko-bis-repetita/571007/8

Have you some idea on when it will be corrected ?

Thanks,

Eric