search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.65k stars 2.3k forks source link

Beta version crash with "goodbyeads ultra" Adblock custom list #36750

Open GodgamingonYT opened 6 months ago

GodgamingonYT commented 6 months ago

Hello Brave developers,

I'm using the latest beta version of Brave on iOS and encountered a crash when I added the "goodbyeads ultra" Adblock custom list. I'm not sure if this is a compatibility issue or a bug within the beta version.

Steps to reproduce:

  1. Opened Brave Beta on iOS
  2. Added "goodbyeads ultra" Adblock custom list
  3. Brave crashed

I'm not sure if this is a one-time issue or if it's related to the custom list. I've since reopened the app and the custom list is saved, but I wanted to report the issue to you in case it's a compatibility issue or bug that needs to be addressed.

Thank you for your time and attention to this matter.

This is written by Leo (the brave AI)

Best regards, Godgaming

antonok-edm commented 6 months ago

Link to the list, for reference: https://raw.githubusercontent.com/jerryn70/GoodbyeAds/master/Formats/GoodbyeAds-Ultra-AdBlock-Filter.txt

It's a pretty large list so this may be running into OOM issues. I confirmed that this doesn't crash when used by adblock-rust directly.

The content blocking JSON is 45MB and doesn't have any validation errors under webkit-content-filter-validator other than Too many rules in JSON array.

ShivanKaul commented 6 months ago

Works fine on Desktop, though may just be a function of memory. cc @cuba