brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Sending feedback form for Leo posts fails [bad request] #36780

Closed Uni-verse closed 6 months ago

Uni-verse commented 6 months ago

Description:

Getting Bad Request for https://feedback.brave.com/1/ai/feedback/form, this seems to be because the rating id is invalid. Swapping the rating id with a valid id such as "rating_id": "8a14836f-0a4e-450f-90ae-334f62b76d4f" via proxy seems to be working (returning 200)

Network Activity:

req:

{
    "category": "Answer is not helpful",
    "feedback": "test",
    "locale": "en_US",
    "rating_id": "3",
    "ymd": "2024-03-13"
}

res:

{
    "Renderer": null,
    "statusCode": 400,
    "error": "Bad Request",
    "message": "invalid rating id"
}

Screenshot 2024-03-13 at 5 05 16 PM

Steps to Reproduce

  1. Enable Leo
  2. Submit query
  3. Long press on response, select Dislike Answer
  4. Tap on Add Feedback on the banner shown in UI
  5. Enter some text and submit form

Actual result:

IMG_5845

Expected result:

Should succeed

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

Device details:

iPhone

kjozwiak commented 6 months ago

Closing as the above is being addressed/fixed via https://github.com/brave/brave-core/pull/22578.

kjozwiak commented 6 months ago

The above requires 1.63.177 or higher for 1.63.x verification 👍

hffvld commented 6 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.63 (177)
BraveCore: 1.63.177 (122.0.6261.128)

STEPS:

  1. Follow the steps from https://github.com/brave/brave-browser/issues/36780#issue-2184921756
  2. Verify

ACTUAL RESULTS:


1 2
1 2