search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.23k forks source link

Add Bookmark > New Folder doesn't save the bookmark in the new folder #36810

Open garrettr opened 4 months ago

garrettr commented 4 months ago

Description:

If I bookmark a page on iOS and choose to save the bookmark in a newly created folder, the folder will be created but the bookmark will be saved in a different location.

Steps to Reproduce

  1. Open a new tab and navigate to any website. I'm using https://fingerprint.com/blog/bypassing-safari-17-audio-fingerprinting-protection/ in the attached screen recording.
  2. Long press the tabs button (bottom toolbar, 2nd from the right)
  3. Tap Add Bookmark
  4. Under Location, tap the folder where the bookmark is to be stored. In the screen recording, the default was Mobile Bookmarks.
  5. Tap New folder. Name the new folder, e.g. "Security", and choose a location, e.g. Other Bookmarks/Resources in the screen recording. Tap Save.
  6. Notice that Location is still Mobile Bookmarks instead of the newly created Security.
  7. Tap Save.
  8. Open ... > Bookmarks to check the results.

Actual result:

The new Security folder was created in the chosen location, but is empty. The bookmark was instead saved in the default location, Mobile Bookmarks.

This screen recording is a demo of the STR. Enable audio for my narration, which should make it easier to follow—iOS doesn't provide a way to visualize the user's touch interactions in the screen recording, so sometimes it's not clear from the video alone which button I pressed at a given step.

https://github.com/brave/brave-browser/assets/407302/fa57d735-5eaa-4ad5-adff-c95eb095b5a2

Expected result:

The bookmark should be saved in the new folder.

Reproduces how often:

Easily reproduced.

Brave Version:

Version 1.62.1 (24.2.29.16)

Device details:

iPhone 14 Pro, iOS 17.4 (21E219)

Additional Information

I use Brave Sync to sync my bookmarks between my phone and my computers. I haven't tried testing this with Brave Sync disabled. I don't know if Brave Sync is involved in this bug (in fact, I very much doubt it), but perhaps it could be? Idk.

kylehickinson commented 3 months ago

Thanks for the report and detailed steps @garrettr, looks like what you pointed out in the video about it showing Mobile Bookmarks after you created the folder is indeed a bug, and is the main bug here. After creating a folder it makes sense it should auto-select that new folder, but right now it doesn't, so unless you manually go and select your new folder by tapping Mobile Bookmarks it would save to the default folder