search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.73k stars 2.31k forks source link

Media Key Handling Flag Disappeared #37038

Open bcrotty opened 6 months ago

bcrotty commented 6 months ago

Description

The #hardware-media-key-handling or #enable-media-key-handling flag allowed you to hide the media overlay box next to the volume control on Windows 10 or on the lockscreen on Windows 10 or 11, but this flag disappeared recently.

Steps to Reproduce

  1. Play media with Brave
  2. Notice the media overlay next to the volume control on Windows 10 or on the lockscreen on Windows 10 or 11
  3. Search for the media key handling flag to disable it
  4. Notice that that setting is missing

Actual result:

Media overlay box appears

Expected result:

Media overlay box should be able to be disabled

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.64.109 Chromium: 123.0.6312.58 (Official Build) (64-bit)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Adding --disable-features=HardwareMediaKeyHandling to the shortcut used to launch Brave fixes this (source), but it would be better to have a browser setting/flag.

ioc2e3 commented 6 months ago

... ?

What happen?

Why was this setting lost?

.

GOAE commented 6 months ago

This is indeed a regression. I used to use global media keys to only control Spotify, but now Brave also handles the media keys after updating whereas it used to be properly disabled. The flag is missing which used to disable global media handling in Brave, and also appears to be missing in the latest version of Chrome (123.0.6312.59). I don't see any flag that may have replaced it. I noticed Chromium got a new global media controls UI, perhaps merging in a new version of Chromium removed the flag, but the new global media UI has nowhere to change any global media-related settings.