getAttachedShaders is failing (WebGL)

Treata11 commented 6 months ago

Test plan

Visit https://www.shadertoy.com/view/X3cXDj
Ensure there are graphics showing in the display portion. It should look like this:

Description

If you head to ShaderToy, you can see the shader previews without any issues. But if you select one to view it in brave (like this example), they simply won't be shown on your screen. Not even when you go full screen.

Steps to Reproduce

Select a desired shader from ShaderToy
You'll instantly notice that the shader fails to compile

Actual result:

You'll only see a black screen. The shaders will fail to compile

Expected result:

The web used to work fine in the previous version of brave & you were able to see the shader.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.64.109 Chromium: 123.0.6312.58 (Official Build) (arm64) Revision ded360c0dc8a4bd8aecb9cbe32a7aa4477d42246 OS macOS Version 14.4 (Build 23E214)

Version/Channel Information:

Can you reproduce this issue with the current release? Yes.
Can you reproduce this issue with the beta channel? Yes.
Can you reproduce this issue with the nightly channel? Haven't tried.

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? No.
Does the issue resolve itself when disabling Brave Rewards? Haven't tried.
Is the issue reproducible on the latest version of Chrome? No.

Miscellaneous Information:

Diffus3d commented 3 months ago

Thank you very much for taking the time to solve this one.

jakeembodiedlabs commented 3 months ago

Thank you!!

kjozwiak commented 3 months ago

The above requires 1.67.129 or higher for 1.67.x verification 👍

zelfroster commented 3 months ago

Thank god, Finally this is fixed 😌🚀

GeetaSarvadnya commented 3 months ago

Verification PASSED on

Brave | 1.67.131 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | e3ca6babc88232bab25830c09164a034adae83bd
OS | Windows 10 Version 22H2 (Build 19045.4529)

Using 1.67.123 Chromium: 126.0.6478.126 and the STR/Cases outlined via https://github.com/brave/brave-core/pull/24446#issue-2384800053 & https://github.com/brave/brave-browser/issues/37044#issue-2205323588, reproduced the original issue as per the following:

`Example`	`Example`

Using the same STR/method as per above, verified that the issue has been resolved via 1.67.131 Chromium: 126.0.6478.126 as per the following:

`Example`	`Example`

catboy-catfish commented 3 months ago

Tested this on windows 10 using the brave nightly build, works perfectly. Thanks guys

brave / brave-browser