search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.52k stars 2.27k forks source link

URL history via bookmarks sent to sync chain only after using search #37071

Open Uni-verse opened 1 year ago

Uni-verse commented 1 year ago

Description:

The url history loaded by opening synced bookmarks will begin to show up in the sync chain history only after using the omnibox.

Consider the following example:

Clean profile (1.43), sync chain connected

After connecting to sync chain, user loads some urls via synced bookmarks but has not yet used omnibox. The urls are not shown in sync chain history on connected devices. Below is screenshot of the history on the device, connected desktop history was empty.

0

Performing a search in the omni box will be sent to sync chain and any urls loaded after will show in sync chain. In this example weather was searched. After using the omnibox, the same urls were loaded from bookmarks: https://www.theverge.com and https://developer.android.com and are now displayed in sync chain across all devices.

iOS (after searching) Desktop (after searching)
IMG_0027 Screen Shot 2022-09-09 at 10 31 30 AM

Steps to Reproduce

  1. Clean install
  2. Connect device to sync chain that contains bookmarks
  3. Enable history in sync settings
  4. Load a few bookmarks
  5. Monitor local history vs sync chain history

Actual result: history is not sent to sync chain

Expected result: All valid urls in history tab should be synced

Reproduces how often: [Easily reproduced, Intermittent Issue] Every time

Brave Version: 1.43

Device details: iPhone, iPad

soner-yuksel commented 1 year ago

This problem is related with other problems happening in History Sync.

Desktop ticket is created https://github.com/brave/brave-browser/issues/25650

Until problems are resolved it will be blocked.