search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.59k stars 2.28k forks source link

[l10n] add bs language #37196

Open AndyAnds265 opened 6 months ago

AndyAnds265 commented 6 months ago

Hello,

We would like to begin supporting the Bosnian language which is indicated by the locale code bs.

We will not be paying for localization services in Bosnian; however we'll be leveraging a combination of resources from Chromium and previously existing translations.

For context, Bosnian, Croatian, Montenegrin and Serbian languages are all very similar languages. In fact, they are fundamentally the same language with some political differences due to their history.

Currently we have a substantial user base in Bosnian but as we do not support the locale bs, all of those users are viewing the app and content in English.

Although it isn't a perfect solution, we would like to copy over the Croatian localizations since it is the closest to Bosnian and the least political.

Therefore, moving forward, can we please use a one-to-many mapping for the hr language:

hr: bs, hr

AndyAnds265 commented 6 months ago

The goal here is to allow us to cover more with less

AndyAnds265 commented 5 months ago

@mkarolin is this something you can handle?

AndyAnds265 commented 5 months ago

@deeppandya or maybe Deep?

mkarolin commented 5 months ago

I looked into this a bit and it seems like, unfortunately, this is not going to be useful. Currently, Chrome (and consequently Brave) doesn't allow to set Bosnian as the UI language on any of the Desktop platforms or on Android (@deeppandya, please let me know if I am wrong). You can add Bosnian to the languages, but on Desktop the option to set it as the UI language is greyed out. On Android, I could set Bosnian as my UI language but it still showed in English, perhaps the entire phone's preferred language needs to be changed, but I have not attempted that. As to why Chrome doesn't support Bosnian as a UI language is not clear to me, perhaps it has something to do with the native platform support for the language (https://source.chromium.org/chromium/chromium/src/+/main:build/config/locales.gni;l=132)

deeppandya commented 5 months ago

yeah we can select Bosniak as one of the language for android. and it seems chromium has translations for Bosniak so it makes sense to include it for brave. @AndyAnds265 do we know how many users we have in the region ?

AndyAnds265 commented 5 months ago

At the moment, we have 7.7k users in Bosnian. This is just Android.

Screenshot 2024-04-18 at 4 14 07 PM

deeppandya commented 5 months ago

@Andy we seem to be missing the support from chromium even though they have the translation file. i also confirmed that with chrome app. changing the language in OS, doesn't do anything for Bosniak.

AndyAnds265 commented 3 months ago

@deeppandya I confirmed by looking in the Chromium files that bs is present. You can see the language here: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/strings/translations/android_chrome_strings_bs.xtb

Since the language is there, is there a way we can contact someone at the Chromium dev side or something? It could be possible that there's a bug in a few languages

AndyAnds265 commented 2 months ago

Just wanted to bump this - any updates?