brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.65k stars 2.3k forks source link

Follow up of #35978 - Self-custody invite displays on top of ToS update notice in the Rewards panel #37211

Closed GeetaSarvadnya closed 6 months ago

GeetaSarvadnya commented 6 months ago

Description

Follow up of #35978 - Self-custody invite displays on the Rewards panel

Steps to reproduce

  1. Follow the STR from https://github.com/brave/brave-browser/issues/37024#issue-2203185817

Actual result

Self-custody invite displays on the Rewards panel

brave://rewards BR panel
Screenshot_20240329_194005_Brave - Beta Screenshot_20240329_194029_Brave - Beta

Expected result

The TOS update notice should be shown on both brave://rewards page and BR panel

Issue reproduces how often

Easy

Version/Channel Information:

Device details

Brave version

1.65.59

Website problems only

Additional information

cc: @brave/qa-team @deeppandya @Miyayes

GeetaSarvadnya commented 6 months ago

The issue is reproducible on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.65.102

brave://rewards Panel
Screenshot_20240405-151835_Brave - Beta Screenshot_20240405-151847_Brave - Beta
kjozwiak commented 6 months ago

The above requires 1.65.110 or higher for 1.65.x verification 👍

GeetaSarvadnya commented 5 months ago

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.65.112

brave://rewards BR panel
Screenshot_20240416_162935_Brave Screenshot_20240416_162959_Brave
GeetaSarvadnya commented 5 months ago

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.65.114

Confirmed that ToS update notice is shown on the brave://rewards and BR panel both

brave://rewards Panel
Screenshot_20240417-175459_Brave Screenshot_20240417-175510_Brave