[Follow up to #36587] `Brave` is still crashing when opening and quickly closing multiple `NTPs`

hffvld commented 6 months ago

Description:

Follow-up to #36587

debug   12:45:33.964658-0700    Client  [ads] Tab id 93003170 was closed
debug   12:45:33.964742-0700    Client  [ads] Triggered event: 08 (0:0:900 s)
debug   12:45:34.016357-0700    Client  [ads] Created tab with id 93003170
debug   12:45:34.016403-0700    Client  [ads] Triggered event: 0D (0:0:900 s)
debug   12:45:34.016438-0700    Client  [ads] Tab id 93003170 did become occluded
debug   12:45:34.016469-0700    Client  [ads] Triggered event: 09 (0:0:900 s)
debug   12:45:34.017515-0700    Client  [ads] Tab id -1860586983 did become focused
debug   12:45:34.017641-0700    Client  [ads] Triggered event: 09 (0:0:900 s)
info    12:45:34.047111-0700    Client  [ads] Failed to get creative new tab page ad
debug   12:45:34.047142-0700    Client  [ads] Failed to fire new tab page ad event due to missing creative instance id 0d3692e8-ab36-4afe-b543-ce401634bee5
debug   12:45:34.047173-0700    Client  [ads] Failed to fire new tab page ad kServed event for placement id 56D6F447-B4B8-41C7-8CB4-3AD1DC2E03B6 and creative instance id 0d3692e8-ab36-4afe-b543-ce401634bee5

Steps to Reproduce

Launch Brave on iPhone or iPad
Settings > Tabs Bar > Enable it
Go back and open any website
Open multiple NTPs (~5 - 10) and quickly close them > Observe Brave is crashing

Actual result:

Brave crashes when opening and quickly closing multiple NTPs. It looks like a Regression, which starts in 1.62, I wasn't able to reproduce it with 1.61.1

iPhone

https://github.com/brave/brave-browser/assets/128532965/f4c575a9-bb4c-46bb-86d5-d94c4f21e715

iPad

https://github.com/brave/brave-browser/assets/128532965/b630c995-ba1f-4ed1-b59d-65ee1f1e01a2

Expected result:

Brave must not crash when opening and closing multiple NTPs

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.65 (96)
BraveCore: 1.65.96 (123.0.6312.86)

Can you reproduce this issue with the most recent build from TestFlight? YES
Can you reproduce this issue with the previous version of the current build from TestFlight? YES
Can you reproduce this issue with the current build from AppStore? YES

Device details:

- iPhone 14 / iOS 17.4.1
- iPad Air / iPadOS 16.7.2

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

cc @kylehickinson

kjozwiak commented 6 months ago

The above requires 1.65.105 or higher for 1.65.x verification 👍

hffvld commented 5 months ago

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.5
- iPad Air / iPadOS 16.7.2
Brave build: 1.65 (112)
BraveCore: 1.65.112 (124.0.6367.29)

STEPS:

Follow the steps from https://github.com/brave/brave-browser/issues/37224#issue-2215929003
Verify

ACTUAL RESULTS:

Verified Brave is not crashing

iPhone

https://github.com/brave/brave-browser/assets/128532965/92ae865f-b3f5-4d90-a759-74eec29ef591

iPad

https://github.com/brave/brave-browser/assets/128532965/f3b1f86b-1965-4948-89c1-a54b9131c2c0

brave / brave-browser