search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.56k stars 2.28k forks source link

[Android] YT Improvements: Fullscreen and PIP floating buttons #37267

Open timchilds opened 5 months ago

timchilds commented 5 months ago

Description

Users have requested an easy way to open full screen and PIP modes on youtube.com. To be more in-line with how the Android YouTube app functions. See https://github.com/brave/brave-browser/issues/32846 and https://github.com/brave/brave-browser/issues/26670 for details.

Requirements

  1. Add a floating button to youtube.com that allows users to open the video in full screen or PIP modes.
    • Buttons should be in fixed position - not possible to move buttons (see design)
  2. Setting to enable/disable under Settings -> Media -> YouTube.
    • Title: Video viewing assistant
    • Description: Adds a button on youtube.com that allows you to easily enter full-screen or picture-in-picture mode.
    • Enabled by default
  3. Put the feature behind a griffin flag: enabled for 100% of users on Nightly/Beta.
    • We'll assess user feedback/reviews on Nightly/Beta.
    • Plus we want a way to quickly disable if we get bad feedback on Release.

Design

https://www.figma.com/file/eQclVYFfDpTgztKDCq9ROk/Youtube-Improvements?type=design&node-id=541-3325&mode=design&t=KeX1Dk8VL1E1kx8N-0 (Option 4)

cc @deeppandya @anthonypkeane

timchilds commented 5 months ago

@rmcfadden3 does the setting title/description copy in the GH description look good to you?

rmcfadden3 commented 5 months ago

Slight tweaks to the settings copy:

Title: Video viewing assistant Description: Adds a button on youtube.com that allows you to easily enter full-screen or picture-in-picture mode.

bridiver commented 4 months ago

Did this get a security review? It's not clear from the description if this is supposed to be something we inject in the page or overlay onto the page, but either way I think it needs review cc @diracdeltas