brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.76k stars 2.32k forks source link

Upgrade from Chromium 124 to Chromium 125. #37333

Closed mkarolin closed 5 months ago

mkarolin commented 6 months ago

Upgrade from Chromium 124 to Chromium 125

https://chromium.googlesource.com/chromium/src/+log/124.0.6367.29...125.0.6382.3/?pretty=fuller&n=10000

QA tests: This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

iOS Affected areas:

Android Affected areas:

GeetaSarvadnya commented 5 months ago

Verification PASSED on

Brave | 1.67.69 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
-- | --
Revision | 3ac44647a57f1d97bd6f702b5c13fd134a352079
OS | Windows 10 Version 22H2 (Build 19045.4291)
All "panels" show up correctly (VPN, Wallet, Rewards, Tipping, Shields)_ **Tipping panel:** - Confirmed that Tipping panel works as expected - Confirmed that user can send a tip successfully - Confirmed that cross custodian tipping panel is shown as expected Example | Example | Example ----------|-----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/2641b494-7ebf-4b2c-9c36-a14fe51700d7) | ![image](https://github.com/brave/brave-browser/assets/38657976/63d7d629-7bb8-4743-98d1-7f829431bd52) | ![image](https://github.com/brave/brave-browser/assets/38657976/62cf5fed-3056-4ab1-959f-84d2e8d1ea19) **Rewards**: - Confirmed that Rewards panel works as expected - Confirmed that publisher info is shown as expected on rewards panel - Confirmed that AC notification shown as expected on BR panel Example | Example | Example | Example ----------|-----------|----------|------ ![image](https://github.com/brave/brave-browser/assets/38657976/0e13475d-f28f-4b24-b0ac-7f99acdffc99) | ![image](https://github.com/brave/brave-browser/assets/38657976/9e662444-363e-43b6-b1b1-3c04ac891381) | ![image](https://github.com/brave/brave-browser/assets/38657976/729f6cf4-14dc-41b2-a550-a891c01204c1) | ![image](https://github.com/brave/brave-browser/assets/38657976/66f03983-55c1-4e0e-ad38-525da29fde87) **Shields** - Shield panel is shown as expected in normal view - Shield panel is shown as expected in advanced view - Shield panel is shown as expected disabled mode Example | Example | Example ----------|-----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/a11eb1a1-d3c9-4f39-a6ef-7e75c596ce3e) | ![image](https://github.com/brave/brave-browser/assets/38657976/ce890a0f-ff5e-45e2-b06a-023372ab63a1) | ![image](https://github.com/brave/brave-browser/assets/38657976/13affd67-04a0-4a5d-a8cd-6a01ba7f48fb) **VPN** - Confirmed that VPN panel is shown as expected in connected state - Confirmed that VPN panel is shown as expected in disconnected state - Confirmed that VPN panel is shown as expected in connecting state - Confirmed that VPN panel is shown as expected in region selection state - Confirmed that VPN panel is shown as expected in error state Example | Example | Example | Example ----------|-----------|----------|--------- ![image](https://github.com/brave/brave-browser/assets/38657976/7d58b0fa-99c9-4d4f-83b5-f6c5b0069eb9) | ![image](https://github.com/brave/brave-browser/assets/38657976/89e0da3d-432a-4a10-aa26-3b1288028a32) | ![image](https://github.com/brave/brave-browser/assets/38657976/889b93c8-b8a7-470f-bdc4-42225a38087a) | ![image](https://github.com/brave/brave-browser/assets/38657976/2a47d8db-6004-4ada-80bc-11e4a15ebabd) | ![image](https://github.com/brave/brave-browser/assets/38657976/e13ed259-da73-4adf-9d16-36153b92632d)
Web Discovery infobar shows up correctly_PASSED - Clean profile `1.67.69 CR 125` - Open brave://settings/search - Confirmed Brave is default search engine in brave://settings/search - Enter a string "hello" in the URL bar - Confirmed that Web discovery info bar is shown - Confirmed that the Web discovery info bar looks correct and all the links/buttons on the info bar works as expected ![image](https://github.com/brave/brave-browser/assets/38657976/883745f4-1658-4930-aae0-97c99eabf9d6)
In DevTools, navigator.brave.isBrave() returns correct value (true in a Promise)_PASSED ![image](https://github.com/brave/brave-browser/assets/38657976/0854426a-5882-40d2-b24b-0cdf6134611b)
VPN installation on Windows works_PASSED - Confirmed that user can connect to VPN without any issues - Confirmed that user can change the VPN region without any issues - Confirmed that user can disconnect and reconnect VPN **Install and connect VPN:** Example | Example | Example ----------|-----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/b8e9a082-c0af-4573-a5c6-0435c7189801) | ![image](https://github.com/brave/brave-browser/assets/38657976/dec3fded-f2dc-4b76-a0f9-236359da7f38) | ![image](https://github.com/brave/brave-browser/assets/38657976/a9eb00d6-bbf3-4ebb-9aa3-aa4fbee06905) **Change the region:** Example | Example | Example ----------|-----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/7fe3c588-e648-4e03-8364-e51560e0023b) | ![image](https://github.com/brave/brave-browser/assets/38657976/141c851f-c69a-4468-a9e3-42168591eea8) | ![image](https://github.com/brave/brave-browser/assets/38657976/a99703a0-d9d5-48db-982a-01e4655d96b0) **Disconnect/reconnect VPN:** Example | Example ----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/5bb74b87-b88e-451a-96ce-e8254bdb88c7) | ![image](https://github.com/brave/brave-browser/assets/38657976/7b2f168d-6c88-488d-b5ae-4eca8086aa3c)
Side panel UI functions as expected_PASSED - Confirmed that Sidebar items looks correctly on the sidebar - Confirmed that click on each item on sidebar works as expected - Bookmarks icon are shown on red color. Logged an issue #https://github.com/brave/brave-browser/issues/38091 ![image](https://github.com/brave/brave-browser/assets/38657976/fafb4566-8834-4a13-b76e-46a5336f6dcb)
Hamburger -> History -> Recent tabs showing correctly_PASSED 1. Confirmed that user can see recent tabs listed under the brave://history 2. Confirmed that date and time is shown correctly for the recent tabs listed under brave://history 3. Confirmed that brave://history is not shown on Tor and Private window tabs ![image](https://github.com/brave/brave-browser/assets/38657976/aeab32dd-946a-4f18-98f0-277a98a640d7)
General Sync functionality_PASSED - Verified the sync functionality in general and it works fine without any issues - When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices - Confirmed the bookmarks syched across all the devices in a sync chain - Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain - When 2 devices are in a sync chain, remove a device resets the sync chain - Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain Example | Example ---------|------------ ![image](https://github.com/brave/brave-browser/assets/38657976/03b18b49-0566-4d1f-93c5-c8d4fc56a451) | ![image](https://github.com/brave/brave-browser/assets/38657976/a2325ee9-f985-441d-bf73-0359a0e53774) |
Shields: cookies control works correctly_PASSED **_Update the cookies setting_** 1. Open a site A and and click on the site information icon and ensured that the third party cookies are blocked on the site A ![image](https://github.com/brave/brave-browser/assets/38657976/93ea107e-2f3a-45a6-8246-cd672bceb436) 2. Go to brave://settings/shields and select `Block all cookies` 3. Reload the site A and click on the site information icon and ensured that the third party cookies are blocked on the site A ![image](https://github.com/brave/brave-browser/assets/38657976/7136fb72-256f-4763-a8f2-4efa574cf338) 4. Open the shield panel on site A and ensure that global cookies settings are applied ![image](https://github.com/brave/brave-browser/assets/38657976/63302336-cc4c-43a2-ab3f-9ab332d77048) 5. Go to brave://settings/shields and select `Allow all cookies` 6. Reload the site A and click on the site information icon and ensured that the cookies are allowed on the site A ![image](https://github.com/brave/brave-browser/assets/38657976/ee3a624e-d80e-47ce-83bf-1da3f230a754) 7. Open the shield panel on site A and ensure that global cookies settings are applied ![image](https://github.com/brave/brave-browser/assets/38657976/6296553f-4b53-4b01-b00e-c196a81ce275) **_Check Allow cookies functionality:_** 1. Clean profile 1.67.x CR 125 2. Go to brave://settings/shields 3. Change cookies settings to `Block all cookies` 4. Open a site A 5. Open shields panel and ensure that block all cookies settings selected in the dropdown 6. Click on site information on a Site A and ensure that all the cookies are blocked ![image](https://github.com/brave/brave-browser/assets/38657976/aa72d789-acba-44ef-beb4-8d7fc8a8fdf0) 7. Go to brave://settings/cookies 8. Click on Add button and add a Site B to allow cookies list ![image](https://github.com/brave/brave-browser/assets/38657976/fa65d15c-880b-4ae8-8d66-6dcab05f73b8) 9. Open site B in a NTP 10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8 ![image](https://github.com/brave/brave-browser/assets/38657976/4009c91d-216b-48b6-9ba3-17df8d2356d5) 11. Open shield panel for site B 12. Ensured that global cookies settings are applied as expected ![image](https://github.com/brave/brave-browser/assets/38657976/179b3fda-6044-4cce-9a87-c82884759d0a) Case 1: 1. Clean profile `1.67.x - CR 125` 14. Open a site 15. Click on the site shield settings 16. Change the trackers and ad blocking settings from `Block third part cookies` to `Block all cookies` 17. Restart the browser 18. Open the site shield settings, confirmed updated cookies settings are retained Case 2: 1. Continuation of case 1 2. Open a site 6. Click on the site shield settings 9. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 10. Restart the browser 11. Open the site shield settings, confirmed updated cookies settings are retained Case 3: 1. Continuation of case 2 2. Open a site 4. Click on the site shield settings 5. Change the trackers and ad blocking settings from `Allow all cookies` to `Block third party site cookies` 6. Restart the browser 7. Open the site shield settings, confirmed updated cookies settings are retained

Settings comparison

1. The `Download` header is renamed as `Download history` via brave://settings/ this is an upstream change, confirmed via https://bravesoftware.slack.com/archives/CU5UXM3EC/p1715012663493819?thread_ts=1714686786.766079&cid=CU5UXM3EC ![image](https://github.com/brave/brave-browser/assets/38657976/c2e9369e-b303-4d4e-98e2-1bcfe7d26406) 2. Profile theme and icons are inherited from CR 125- Logged a follow up issue #38087 ![image](https://github.com/brave/brave-browser/assets/38657976/7254fee4-6763-428a-a084-75e3fdc8a654) 3. Block cookies shield settings dropdown items are changed and it is addressed by the issue https://github.com/brave/brave-browser/issues/37305 ![image](https://github.com/brave/brave-browser/assets/38657976/73e064b6-44d0-40b2-a73c-64d8024ebede) 4. Third part cookies settings is removed from brave://settings/privacy and it is addressed by the issue https://github.com/brave/brave-browser/issues/37305 ![image](https://github.com/brave/brave-browser/assets/38657976/0ac68792-54a1-4956-8f52-6f8cccd8449a) 5. A new content settings `Scrolling & zooming` is added via brave://settings/content ![image](https://github.com/brave/brave-browser/assets/38657976/b465ab1c-d5cb-4b70-91bd-08f7145e0f88)

Brave startup calls

GeetaSarvadnya commented 5 months ago

@srirambv: Could you verify the following wallet related items on Desktop? Thanks!

  1. Brave Wallet: Solana functionality
  2. Brave wallet can import legacy wallet
srirambv commented 5 months ago

Verification passed on

Brave 1.67.69 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
Revision 3ac44647a57f1d97bd6f702b5c13fd134a352079
OS Linux
Uni-verse commented 5 months ago

Verified on Samsung Galaxy Tab S7 using version:

Brave   1.67.69 Chromium: 125.0.6422.26 (Official Build) canary (64-bit) 
Revision    3ac44647a57f1d97bd6f702b5c13fd134a352079
OS  Android 13; Build/TP1A.220624.014; 33; REL
URL bar UI 1.67.58 | 1.67.69 | 1.67.69 -|-|- ![Screenshot 2024-05-06 at 5 40 41 PM](https://github.com/brave/brave-browser/assets/17885425/5b08de68-bcc6-4e93-bd91-198c27b63af9) | ![Screenshot 2024-05-06 at 5 43 05 PM](https://github.com/brave/brave-browser/assets/17885425/b357f9c4-6f7f-484b-8e21-d2af49d6a765) | ![Screenshot 2024-05-06 at 3 07 09 PM](https://github.com/brave/brave-browser/assets/17885425/e4dc8efe-0966-423b-a154-f3db3bff622c)
Tab overview UI - Ensured all options in Tab overview UI are functional and all nothing has regressed. - Ensured that Tab overview UI has not changed. Example | Example | Example | Example -|-|-|- ![Screenshot 2024-05-06 at 1 07 59 PM](https://github.com/brave/brave-browser/assets/17885425/f4ef7b13-00c6-4c99-a9e9-e44774d535d4) | ![Screenshot 2024-05-06 at 1 08 04 PM](https://github.com/brave/brave-browser/assets/17885425/16583d1e-de9f-4a94-b5c9-09214a4dab1c) | ![Screenshot 2024-05-06 at 1 08 18 PM](https://github.com/brave/brave-browser/assets/17885425/608757d8-f56e-4992-ba5f-c9c60aad0ec7) | ![Screenshot 2024-05-06 at 1 09 08 PM](https://github.com/brave/brave-browser/assets/17885425/cd762e77-780b-4a38-b9f3-629c8b0893a7)
NTP Layout - Ensured NTP elements are shown correctly. - Ensured disabling each of the options in `New Tab Page` setting will be reflected in the tab after restart. Example | Example | Example -|-|- ![Screenshot 2024-05-06 at 1 21 13 PM](https://github.com/brave/brave-browser/assets/17885425/99bb6f01-f635-48c6-a9be-cfee06f62c87) | ![Screenshot 2024-05-06 at 1 32 56 PM](https://github.com/brave/brave-browser/assets/17885425/78070133-fff5-4082-850e-5b14692dba21) | ![Screenshot 2024-05-06 at 5 04 41 PM](https://github.com/brave/brave-browser/assets/17885425/64a16955-1d88-46ee-856b-4bf4056b3f74)
brave://version - Ensured that apk version code has correct format. ![Screenshot 2024-05-06 at 1 06 14 PM](https://github.com/brave/brave-browser/assets/17885425/d4419855-c2ca-4212-b672-fba03fb061e5)
Sync (QR code) - Ensured joining sync chain is success when using QR code option. Example | Example | Example | Example -|-|-|- ![Screenshot 2024-05-06 at 1 09 28 PM](https://github.com/brave/brave-browser/assets/17885425/ff8d9c98-d197-4755-8432-bd1de618b185) | ![Screenshot 2024-05-06 at 1 09 32 PM](https://github.com/brave/brave-browser/assets/17885425/c8e5d2f8-58c6-4b88-a5ab-bd7f77870768) | ![Screenshot 2024-05-06 at 1 10 00 PM](https://github.com/brave/brave-browser/assets/17885425/16f542eb-2875-4f8f-a3fa-80ab0d1163f9) | ![Screenshot 2024-05-06 at 1 10 05 PM](https://github.com/brave/brave-browser/assets/17885425/b3600494-e97e-464d-96a4-2538ae9731ea)
Open YouTube links in Brave - Ensured that YouTube links open in Brave when `Open YouTube links in Brave` setting is enabled (default) - Ensured that YouTube links are opened outside of Brave when setting is disabled. Example | Example -|-|- ![Screenshot 2024-05-06 at 1 17 59 PM](https://github.com/brave/brave-browser/assets/17885425/f6428201-ddc3-4bf4-abfe-ad519612c087) | ![Screenshot 2024-05-06 at 1 18 04 PM](https://github.com/brave/brave-browser/assets/17885425/80608a6d-77a3-4579-a8e6-b27adfe9075e)
Autoplay option - Ensured AutoPlay setting is applied to videos on websites. - Ensured that exceptions are working. Example | Example | Example -|-|- ![Screenshot 2024-05-07 at 2 08 34 PM](https://github.com/brave/brave-browser/assets/17885425/fe60d376-c1b7-4551-b63d-798c47efc11b) | ![Screenshot 2024-05-07 at 2 10 52 PM](https://github.com/brave/brave-browser/assets/17885425/ab5fcb15-bdd3-4484-958e-54040a7ad78d) | ![Screenshot 2024-05-07 at 2 22 02 PM](https://github.com/brave/brave-browser/assets/17885425/a1fc13fd-9d6e-48ec-9791-8dc2bba5e376)
Check issue #27651) - Ensured there are no issues and searches on normal tab with open private tabs. ![Screenshot 2024-05-06 at 1 23 08 PM](https://github.com/brave/brave-browser/assets/17885425/4b3e7fd3-9987-44b7-94bb-38c5e7698561)
Uni-verse commented 5 months ago

Verified on Samsung Galaxy S21 using version:

Brave   1.67.70 Chromium: 125.0.6422.26 (Official Build) canary (64-bit) 
Revision    d50f557a6553f6cbd622cf49c6378712ee4217a8
OS  Android 13; Build/TP1A.220624.014; 33; REL
URL bar UI Example | Example -|- ![Screenshot 2024-05-07 at 12 49 10 PM](https://github.com/brave/brave-browser/assets/17885425/d2e37ead-ed56-421c-aabf-3ab44ebf2945) | ![Screenshot 2024-05-07 at 1 56 40 PM](https://github.com/brave/brave-browser/assets/17885425/7b326038-25a5-4f44-b3ea-2da465625221)
Tab overview UI - Ensured all options in Tab overview UI are functional and all nothing has regressed. - Ensured that Tab overview UI has not changed. Example | Example | Example | Example -|-|-|- ![Screenshot 2024-05-07 at 12 58 06 PM](https://github.com/brave/brave-browser/assets/17885425/55cf465c-59ab-44bb-8d6c-72b777086f7b) | ![Screenshot 2024-05-07 at 1 52 18 PM](https://github.com/brave/brave-browser/assets/17885425/505da9bf-75f3-4a4c-9f48-1100fec4de98) | ![Screenshot 2024-05-07 at 1 52 24 PM](https://github.com/brave/brave-browser/assets/17885425/93b9254e-d470-4d5e-ab1d-2222a99b9441)
NTP Layout - Ensured NTP elements are shown correctly. - Ensured disabling each of the options in `New Tab Page` setting will be reflected in the tab after restart. Example | Example | Example | Example -|-|-|- ![Screenshot 2024-05-07 at 12 50 48 PM](https://github.com/brave/brave-browser/assets/17885425/eb5c3d60-331d-4754-9226-a175c0bb1580) | ![Screenshot 2024-05-07 at 12 50 53 PM](https://github.com/brave/brave-browser/assets/17885425/570b1417-232f-42f6-9e44-d755b18137b0) | ![Screenshot 2024-05-07 at 12 50 59 PM](https://github.com/brave/brave-browser/assets/17885425/2a6fe02d-7bd3-43cf-a586-1520416abdb4) | ![Screenshot 2024-05-07 at 12 52 01 PM](https://github.com/brave/brave-browser/assets/17885425/714387e1-2f50-4a15-8470-8a7679e9be82)
brave://version - Ensured that apk version code has correct format. ![Screenshot 2024-05-07 at 1 39 59 PM](https://github.com/brave/brave-browser/assets/17885425/f2876f83-c398-44f8-84eb-e9d398e852ad)
Sync (QR code) - Ensured joining sync chain is success when using QR code option. Example | Example | Example -|-|- ![Screenshot 2024-05-07 at 12 59 20 PM](https://github.com/brave/brave-browser/assets/17885425/5fe0a4b0-bdce-4afe-af1a-fe1a18db4dc5) | ![Screenshot 2024-05-07 at 12 59 25 PM](https://github.com/brave/brave-browser/assets/17885425/c34ce521-cf8a-416e-8a96-1b81c617ca40) | ![Screenshot 2024-05-07 at 1 48 07 PM](https://github.com/brave/brave-browser/assets/17885425/0c6e3f3a-3727-4a05-bebe-2c448cb27e47)
Open YouTube links in Brave - Ensured that YouTube links open in Brave when `Open YouTube links in Brave` setting is enabled (default) - Ensured that YouTube links are opened outside of Brave when setting is disabled. Example | Example -|- ![Screenshot 2024-05-07 at 12 56 11 PM](https://github.com/brave/brave-browser/assets/17885425/0e385c8b-2f7b-40af-b525-dcc03e921e97) | ![Screenshot 2024-05-07 at 12 56 17 PM](https://github.com/brave/brave-browser/assets/17885425/75796791-7e8d-402d-abbf-f748dadabb2c)
Autoplay option - Ensured that Autoplay site setting is enabled by default. - Ensured that blocking Autoplay will disabled autoplay for videos on sites. - Ensured that adding an allow exception for `m.youtube.com` will autoplay videos on youtube when blocking is enabled.
Check issue #27651) - Ensured there are no issues and searches on normal tab with open private tabs. ![Screenshot 2024-05-07 at 1 53 40 PM](https://github.com/brave/brave-browser/assets/17885425/3b117557-ecf4-46ea-aea2-51511ce37fbe)
Uni-verse commented 5 months ago

Verified on iPhone 12 running iOS 17.3.1 using version 1.67.73 (125.0.6422.26)

Example Example Example Example
IMG_6082 IMG_6083 IMG_6084 IMG_6085
IMG_6086 IMG_6087 IMG_6088 IMG_6089 IMG_6090
kjozwiak commented 5 months ago

The above requires 1.66.104 or higher for 1.66.x verification 👍

kjozwiak commented 5 months ago

Labelling as QA/No & release-notes/exclude in favor of https://github.com/brave/brave-browser/issues/38166#issuecomment-2101716260.