Open ShivanKaul opened 7 months ago
In my opinion, it should be rewritten and rethought. I love that I can block scripts with Brave itself, I find using extensions that do the same messing up Brave specifically, so I would love for Brave to have this improved.
I used a few extensions (2 or 3, but separately) that block the scripts I want to block, and NoScript was the best extension for it. However, as much as it was flawless on other browsers (Ungoogled Chromium, Firefox, Librewolf), on Brave it always has some issues, sometimes minor, sometimes major (not loading some websites even though the extension is set to allow all scripts), so "baking in" (not literally) NoScript would be the best idea, as in improving and rewriting the Brave Shield script blocking so that it works the same (or as close to the same) as in NoScript. Currently, it works almost the same, the only difference (that I noticed) is that Brave does not remember the scripts you allow or block, which is something that NoScript does - you can disable some scripts on a website, close the website or browser, open it again and the same scripts are blocked and allowed. Having to manually re-enable/re-disable scripts every time you re-open the website or change the page is the definition of tortures.
We currently allow users to block scripts globally (in brave://settings/shields) or on a per-site basis (Shields panel), and then let them opt-in to specific scripts on a per-site basis.
This is a powerful but niche feature. Chromium has gotten rid of the code needed for this feature, which means we now have to maintain increasingly brittle code to support this.
At this point, we should treat this as a new feature and either do a complete rewrite or get rid of it. We're evaluating whether it's worth writing the feature from scratch, given that existing Web Extensions (like uMatrix) already handle this advanced use-case.