search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.65k stars 2.3k forks source link

Asset Icons not loading in Wallet #37430

Closed Douglashdaniel closed 5 months ago

Douglashdaniel commented 6 months ago

Description

Some assets are not loading Icons in the Wallet

Steps to Reproduce

  1. Open the Wallet and navigate to the Portfolio screen
  2. Some asset icons are not loading

Actual result:

Screenshot 6

Screenshot 7

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

srirambv commented 5 months ago

Verification passed on

Brave 1.66.90 Chromium: 124.0.6367.82 (Official Build) beta (64-bit)
Revision 803a4c629341791205b744969c48b8da9f2cfa4d
OS Windows 11 Version 23H2 (Build 22631.3527)

https://github.com/brave/brave-browser/assets/17010094/9a8febf1-adcf-4396-a20c-e3f4eb2305db

kjozwiak commented 5 months ago

The above requires 1.65.129 for higher for 1.65.x verification 👍 Removing QA Pass as we'll need to quickly re-verify via 1.66.x. However, used https://github.com/brave/brave-browser/issues/37430#issuecomment-2082086787 as the verification needed for uplift as per https://github.com/brave/brave-core/pull/23439#pullrequestreview-2041941484.

srirambv commented 5 months ago

Verification passed on

Brave 1.65.129 Chromium: 124.0.6367.118 (Official Build) (64-bit)
Revision 044ca9dfdf2f9053cb9a344d13924d255079e9a9
OS Windows 11 Version 23H2 (Build 22631.3527)

https://github.com/brave/brave-browser/assets/17010094/f3801c19-9944-4ee4-9097-08a964480d1d