Closed GauthamVarmaK closed 5 years ago
cc: @rebron to add steps to reproduce
If I am right, I already added.
Same issue on MacOS when trying to open an installed PWA, works fine with Chrome... Also the file size is different when installing from Brave vs installing in Chrome due to the 'app_mode_loader' inside the package...
```
Process: app_mode_loader [62193]
Path: /Users/USER/*/Intelligence Fusion.app/Contents/MacOS/app_mode_loader
Identifier: com.brave.Browser.app.Default-cplggelhfenffcioaehccpojieagpfhh
Version: 2019.3.25.45879 (61.52)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: app_mode_loader [62193]
User ID: 502
Date/Time: 2019-03-25 16:48:11.046 +0000
OS Version: Mac OS X 10.14.3 (18D109)
Report Version: 12
Anonymous UUID: D9090F99-FD7D-9C5E-3225-FCD4CDE104F4
Sleep/Wake UUID: 8A7CBA4D-4620-4E8A-AA92-F1710617659A
Time Awake Since Boot: 290000 seconds
Time Since Wake: 27000 seconds
System Integrity Protection: enabled
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000002, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Trace/BPT trap: 5
Termination Reason: Namespace SIGNAL, Code 0x5
Terminating Process: exc handler [62193]
Application Specific Information:
dyld2 mode
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 com.brave.Browser.app.Default-cplggelhfenffcioaehccpojieagpfhh 0x0000000100935ca4 0x100769000 + 1887396
1 com.brave.Browser.app.Default-cplggelhfenffcioaehccpojieagpfhh 0x000000010076b153 0x100769000 + 8531
2 com.brave.Browser.app.Default-cplggelhfenffcioaehccpojieagpfhh 0x000000010076ad9b main + 27
3 libdyld.dylib 0x00007fff79f40ed9 start + 1
Thread 1:
0 libsystem_pthread.dylib 0x00007fff7a1333f8 start_wqthread + 0
1 ??? 0x0000000054485244 0 + 1414025796
Thread 2:
0 libsystem_pthread.dylib 0x00007fff7a1333f8 start_wqthread + 0
Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000 rbx: 0x00007fffacd199a0 rcx: 0x0000000000000000 rdx: 0x0000000000000400
rdi: 0x00007ffeef4962c0 rsi: 0x00007ff4cb906cb0 rbp: 0x00007ffeef496790 rsp: 0x00007ffeef496260
r8: 0x00000000000130a8 r9: 0x0000000000000000 r10: 0x00007fffacd19048 r11: 0x00007fffacd19040
r12: 0x00007ff4cb906cb0 r13: 0x00007ffeef4962a8 r14: 0x00007ffeef4968a0 r15: 0x00007ffeef4968b0
rip: 0x0000000100935ca4 rfl: 0x0000000000000246 cr2: 0x00007fffacd1c260
Logical CPU: 0
Error Code: 0x00000000
Trap Number: 3
Binary Images:
0x100769000 - 0x100c1afd7 +com.brave.Browser.app.Default-cplggelhfenffcioaehccpojieagpfhh (2019.3.25.45879 - 61.52)
App never launches. Doesn't crash browser though. crash-report.txt
Process: app_mode_loader [16144]
Path: /Users/USER/*/Brave Software Mail.app/Contents/MacOS/app_mode_loader
Identifier: com.brave.Browser.nightly.app.Default-miilmjmgkdhdabfkjkilgecbhbchboem
Version: 2019.3.25.46181 (64.8)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: app_mode_loader [16144]
User ID: 501
Date/Time: 2019-03-25 09:54:46.290 -0700
OS Version: Mac OS X 10.14.4 (18E220a)
Report Version: 12
Bridge OS Version: 3.4 (16P54506a)
Anonymous UUID: 4DC71979-379C-7ED6-298F-0ADC54BEDBBE
Sleep/Wake UUID: 0B305DAD-19EC-41CA-9A92-F10DB07771E9
Time Awake Since Boot: 160000 seconds
Time Since Wake: 2100 seconds
System Integrity Protection: enabled
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000002, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Trace/BPT trap: 5
Termination Reason: Namespace SIGNAL, Code 0x5
Terminating Process: exc handler [16144]
Application Specific Information:
dyld2 mode
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 com.brave.Browser.nightly.app.Default-miilmjmgkdhdabfkjkilgecbhbchboem 0x0000000102f69ca4 0x102d9d000 + 1887396
1 com.brave.Browser.nightly.app.Default-miilmjmgkdhdabfkjkilgecbhbchboem 0x0000000102d9f153 0x102d9d000 + 8531
2 com.brave.Browser.nightly.app.Default-miilmjmgkdhdabfkjkilgecbhbchboem 0x0000000102d9ed9b main + 27
3 libdyld.dylib 0x00007fff6dde43d5 start + 1
Thread 1:
0 libsystem_pthread.dylib 0x00007fff6dfd13f0 start_wqthread + 0
Thread 2:
0 libsystem_pthread.dylib 0x00007fff6dfd13f0 start_wqthread + 0
Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000 rbx: 0x00007fffa0df19a0 rcx: 0x0000000000000000 rdx: 0x0000000000000400
rdi: 0x00007ffeece622a0 rsi: 0x00007ff7926061d0 rbp: 0x00007ffeece62770 rsp: 0x00007ffeece62240
r8: 0x00000000000130a8 r9: 0x00007fffa0df1048 r10: 0x0000000000000000 r11: 0x00007fffa0df1040
r12: 0x00007ff7926061d0 r13: 0x00007ffeece62288 r14: 0x00007ffeece62880 r15: 0x00007ffeece62890
rip: 0x0000000102f69ca4 rfl: 0x0000000000000246 cr2: 0x00007fffa0df4260
Logical CPU: 2
Error Code: 0x00000000
Trap Number: 3
Binary Images:
0x102d9d000 - 0x10324efd7 +com.brave.Browser.nightly.app.Default-miilmjmgkdhdabfkjkilgecbhbchboem (2019.3.25.46181 - 64.8) <849EA8AC-C5DA-3544-899B-8776F1C65E0A> /Users/USER/*/Brave Software Mail.app/Contents/MacOS/app_mode_loader
0x10c002000 - 0x10c06c6ef dyld (655.1.1) <87B0AA37-BB9A-35ED-BB78-3319BD97A1B6> /usr/lib/dyld
0x7fff3ddbb000 - 0x7fff3ddbbfff com.apple.Accelerate (1.11 - Accelerate 1.11)
Same here on Windows 10 1809 and Brave 0.62.50. Quite annoying because I have to open these shortcuts with Chrome while waiting for a fix. This does not generate a crash report in brave://crashes however...
It's happening because it links the website to the chrome_proxy.exe
in the startup command line. Changing it to brave.exe
fixes the problem. As you can see here:
It's not reproducible on Linux btw. This works there.
It's happening because it links the website to the
chrome_proxy.exe
in the startup command line. Changing it tobrave.exe
fixes the problem. As you can see here:It's not reproducible on Linux btw. This works there.
Thank you, it works !
+1 from Community https://community.brave.com/t/shortcuts-dont-work-on-pc/53857?u=eljuno
as @BenDavidson90 stated, another user from Community reports PWAs fixdd by changing chrome_proxy.exe
to brave.exe
https://community.brave.com/t/progressive-web-apps-dont-work-properly-on-windows-easy-fix-included/54610
Anyone have a fix for MacOS? Thank you in advance.
@GauthamVarmaK @jordmccord @rebron Consider editing your comments to wrap the crash report in a "spoilers" area. This thread is difficult to navigate.
Fix for Windows is merged - https://github.com/brave/brave-core/pull/2544 Separate issue was created for Windows(https://github.com/brave/brave-browser/issues/4654). So, only macos label is added in this PR.
+1 here
For folks following along, this should be fixed in our Nightly channel 🎉 Huge thanks to @simonhong 😄
We're working to uplift the patch back to beta (0.66.x). That means the fixes will hit release channel ~July 2nd
Verification PASSED on macOS 10.14.5 x64
using the following build:
Brave | 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta(64-bit) |
---|---|
Revision | 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948} |
OS | Mac OS X |
Should this be fixed in Windows? It's still not working here, and the "change chrome_proxy.exe to brave.exe in the shortcut" workaround doesn't seem to work here, either.
It's working now in my Mac Mojave.
@JudahGabriel what version of Brave are you using on Windows? It should be working there
@bsclifton Brave v0.68.132, on Windows 10 Enterprise.
My repro steps:
Hmm, I can't repo on my Win10 home. It works well with 0.68
Brave Version : 1.5.123
OS: macOS 10.15.4
Unfortunately, the problem report is not received in brave: // crashes. For more information, see: #9006
Still crashing for me
Brave: Version 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)
OS: macOS 10.15.3 Catalina
Not working for YouTube Music (music.youtube.com). It doesn't open in it's own app but in a new tab in Brave. Tried changing chrome_proxy.exe to brave.exe, still same result. It appears to be working on other sites like YouTube, Spotify and GitHub even without changing the chrome_proxy.exe to brave.exe
Brave Version 1.18.78 Chromium: 87.0.4280.141 (Official Build) (32-bit)
OS: Windows 10 Pro Version 20H2 OS Build 19042.685
Still an issue here on Mac. It will open the shortcut just fine, but if you move the window it will crash.
https://user-images.githubusercontent.com/757960/106067236-7f8c8b00-60bb-11eb-8ddb-961b67131be6.mov
Shortcut opening broke on the most recent update for Mac OS (V1.35.104 for Mac). Shortcuts were working on previous version. Updating Brave broke the shortcuts, and re-generating the shortcuts does not fix.
edit: Installed Brave Beta (V1.37.72 for Mac) and still has this issue. I am able to successfully create the shortcut and corresponding app/icon, but opening the app/icon causes the app to appear briefly in the dock before disappearing, and never opens a new window or appropriate web page.
I am seeing the same behavior as @DeadDjembe after the most recent update for macOS. I tried looking through the logs in Console.app but didn't notice anything relevant.
Appears to be working again.
Description
Facing problems with creating PWA by using the Create Shortcut option (with or without Open as window ) in the More Tools group under the Contorl and Customize Brave section. On creating a shortcut, it would create a shortcut on the Desktop. However on clicking the shortcut the PWA won't open and would load for ever
Potential work-around
See https://github.com/brave/brave-browser/issues/3750#issuecomment-480103072
Test plan / Steps to Reproduce
Actual result:
It would take forever to load
Expected result:
It should open up as a window or a tab
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit) Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803} OS Windows 10 OS Build 17763.379 JavaScript V8 7.3.492.22 Flash (Disabled) User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36 Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=NewExtensionUpdaterService,DesktopPWAWindowing,fill-on-account-select --disable-features=AutofillServerCommunication,DefaultEnableOopRasterization,AudioServiceOutOfProcess,AutofillSaveCardSignInAfterLocalSave,UnifiedConsent,SharedArrayBuffer --flag-switches-begin --flag-switches-end Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe Profile Path C:\Users\gauth\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default Variations c134752e-f685ead3 2c707b42-dcf7018a 411b6d4e-3f4a17df d01ab0d3-5ac8943 1a0d11d4-2f9febdf 66df3e9d-a85d0b2f 4b8c3f4-3f4a17df b7e2524c-c92d551c 411c711e-3f4a17df b3888d8d-afba0f91 8982496f-3f4a17df 61832c80-3f4a17df cc20827f-77c422c 2db4845-ace4e138 74785582-3f4a17df 241fff6c-ddf20878 9853922b-3f4a17df 9def365c-3f4a17df 2342e907-3f4a17df 9ca1387e-3f4a17df 1c752ce9-1c752ce9 41e765a5-3f4a17df ab3d6cfd-3f4a17df 776de70c-e0278d3d ed9149a9-3f4a17df a5cb8590-3f4a17df 34d450b1-3f4a17df 6c6c4f61-3f4a17df 76b48ab8-d4bd105c c70841c8-a2567007 14bdbe54-e8c7a65b d8343fa3-3f4a17df b517d646-3f4a17df 8ee5ed19-c3125ea2 74658432-fa79b94c f978f5fa-3f4a17df c36cdb78-3f4a17df 9e201a2b-3f4a17df 27212adc-27212adc 591576c8-3f4a17df 5274eb09-3f4a17df 36115667-3f4a17df ceff87ec-3f4a17df 44827ee5-3f4a17df 8ca44045-3f4a17df 3f79ac13-3d47f4f4 8f1e27f-3f4a17df 77bbdddc-3f4a17df 5485fc4d-3f4a17df de47491b-3f4a17df 9b4c4257-3f4a17df 8fa604e0-ace4e138 43f62d3b-3f4a17df 4ae380f4-3f4a17df 9e5c75f1-30e1b12b 2594bdf4-3f4a17df 6fa07eb4-7282ca76 2981bcb4-3f4a17df 5139837c-3f4a17df 4934552d-3f4a17df 7f8176d9-3f4a17df 23a898eb-fc93cf74 7a5ba892-3f4a17df d1cd70a5-80f9a33e 4ea303a6-3f4a17df ac8d4708-e340be04 b19465ab-b19465ab 6e6e0c7e-3f17a7d8 95876445-2b71ffe4 2b33233e-881ca6c9 b363a81f-3f4a17df 4da5ae82-3f4a17df 56302f8c-2f882e70 dc5b1f29-dc5b1f29 bbc5c1b-3f4a17df cc54eb06-803f8fc4 b2612322-8a9180b2 cac0a91c-3f4a17df cec9a952-9a6c5085 f56e0452-3f4a17df 8576baf1-3f4a17df f3ea30a0-3f4a17df 3038aa2e-3f4a17df d00fcbde-3f4a17df 9a2f4e5b-4bc735ae 1354da85-f1a864dc 6844d8aa-669a04e0 494d8760-3f4a17df f9e5da91-508355f5 fcdd9ed9-fcdd9ed9 3a4029d-d7f231f3 b0ea13bc-3f4a17df 3a8217c1-38848f64 94e68624-803f8fc4 cc73f8a1-3f4a17df b4e8892d-a2d707c6 10a311eb-10a311eb 8834fcca-3f4a17df 6204e469-3f4a17df
Website problems only:
Additional Information
Would update the issue when it's working.