brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.11k stars 2.23k forks source link

Default browser on Win10 doesn't open links from 3rd parties #3758

Open arisAlexis opened 5 years ago

arisAlexis commented 5 years ago

Description

After making Brave the default browser on Windows 10, links from slack,discord stop opening links.

Steps to Reproduce

  1. Make Brave default browser
  2. Open slack
  3. Follow link with click doesn't open

Actual result:

Nothing

Expected result:

Open a new window with the link

Brave version (brave://version info)

Version 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)

Reproducible on current release:

rebron commented 5 years ago

cc: @kjozwiak need more info.

kjozwiak commented 5 years ago

@arisAlexis I couldn't reproduce the issue you're experiencing using the following build under Win 10 x64:

Brave  | 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
--- | ---
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Windows 10 OS Build 17763.348

Does Brave appear as your default browser under Windows settings? What happens if you try setting Brave as the default browser again using brave://settings. Do you have multiple Brave installations?

arisAlexis commented 5 years ago

Brave is my default browser in windows and in the brave://setttings. The problem (which is not really so big because whatsapp opens links for example) started when I switched from Chrome to Brave. Slack and discord both don't open the links. Did you try with slack for example?

kjozwiak commented 5 years ago

@arisAlexis yup, I tried with both Slack & Discord and the links are opening in Brave which is set as the default browser. Are both http & https associated with Brave? You check by going into Default Apps --> Set defaults by app --> Click on Brave --> Manage. Quick example:

Screen Shot 2019-03-21 at 12 54 25 AM
arisAlexis commented 5 years ago

yes both http/https were and I found a third app that does it, Pokerstars client. It doesn't find a default app and it needs manual reconfiguring. I think there is something there and it's quite a serious bug if the goal is to make users switch completely to Brave.

rebron commented 5 years ago

cc: @Brave-Matt this looks like we need to move to support and this might be a config issue. Anything you can think of here? Let's get some more details on OS as well.