Private windows redesign - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.6k stars 2.28k forks source link

Private windows redesign #37596

Open aguscruiz opened 5 months ago

aguscruiz commented 5 months ago

We need to redesign private windows to present information in a friendlier way.

Design ready here: https://www.figma.com/design/jt7tV0UsU7XhJXR2B8807E/Private-and-Tor-Windows---Nala?node-id=37%3A7636&t=wKzZwmhqCGW5ylK4-1

Actual result

Android

Sorry for the photo, doesn't let me take screenshots.

Expected result

Issue reproduces how often

Version/Channel Information:

Can you reproduce this issue with the current Play Store version?
Can you reproduce this issue with the current Play Store Beta version?
Can you reproduce this issue with the current Play Store Nightly version?

Device details

Install type (ARM, x86):
Device type (Phone, Tablet, Phablet):
Android version:

Brave version

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

ghost commented 5 months ago

Just want to be nosey and tell you that to take screenshots in private mode you just need to enable brave://flags/#incognito-screenshot

aguscruiz commented 5 months ago

Just want to be nosey and tell you that to take screenshots in private mode you just need to enable brave://flags/#incognito-screenshot

Oh thanks! Didn't know that 👏