brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.11k stars 2.23k forks source link

[Perf] Memory regression after updating profiles (v1.67.16 => v1.67.17) #37643

Open atuchin-m opened 3 months ago

atuchin-m commented 3 months ago

Android: all_processes:reported_by_chrome:allocated_objects_size / load_site / example.com: 98.4 MB => 105.8 MB (+7.4MB) It's likely a result of adblock list update.

image
atuchin-m commented 3 months ago

The extra memory is in malloc category in the browser process. The dumps:

Screenshot 2024-04-17 at 10 25 11 AM Screenshot 2024-04-17 at 10 25 27 AM
atuchin-m commented 3 months ago

The size of the default adblock list (iodkpdagapdfkphljnddpjlldadblomo) has been changed 4.9M => 5.3M. This is likely the reason of the regression. It's not clear why only Android is affected.

mikhail@am-macbook-2 /tmp % du -h -t 100K new_android/iodkpdagapdfkphljnddpjlldadblomo 
5.3M    new/iodkpdagapdfkphljnddpjlldadblomo/1.0.5215

mikhail@am-macbook-2 /tmp % du -h -t 100K old_android/iodkpdagapdfkphljnddpjlldadblomo
4.9M    old/iodkpdagapdfkphljnddpjlldadblomo/1.0.3629

mikhail@am-macbook-2 /tmp % du -h -t 100K old_win/iodkpdagapdfkphljnddpjlldadblomo                  
4.9M    old_win/iodkpdagapdfkphljnddpjlldadblomo/1.0.3628

mikhail@am-macbook-2 /tmp % du -h -t 100K new_win/iodkpdagapdfkphljnddpjlldadblomo
5.3M    new_win/iodkpdagapdfkphljnddpjlldadblomo/1.0.5215
atuchin-m commented 3 months ago

UPD: the other platforms are also affected. mac-arm64:

Screenshot 2024-04-18 at 3 54 58 PM