brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.22k forks source link

[i18n] Chinese locale mappings #37675

Open AndyAnds265 opened 2 months ago

AndyAnds265 commented 2 months ago

Hello,

I'd like do a quick sanity check for the Chinese locales. There are two main forms of written Chinese: Simplified and Traditional. The writing systems are not interchangeable.

Simplified is primarily used by the following countries:

Traditional is primarily used by the following countries/territories:

At the moment, our mappings are just zh and zh-TW. zh by itself really isn't a language. In spoken Chinese, there are 100s of languages. In written form, there are just 2 mainly used.

In Xcode, we should have the option to add by script correct? For example, can we determine:

OR, can we figure out a way to ensure that zh-MO, zh-HK users will also get zh-TW?

Since Brave has functionally no major market in China due to privacy issues, it is in our best interest to optimize for the Traditional Chinese users.

Please let me know if you have any questions - I'm happy to walk through this.

Screenshot 2024-04-17 at 23 53 18

AndyAnds265 commented 2 months ago

for reference: https://github.com/brave/brave-core/blob/2b6deb38dd1765db0c6973c352e22388dffd68cd/ios/brave-ios/App/l10n/tools/download-translations-from-transifex.swift#L4

larreewong commented 2 months ago

@AndyAnds265 - I've set my iPhone to HK, TW and Macao regions with the preferred language (Traditional). I see Chinese (Traditional) show up correctly in our Brave app. Let me know if you have any questions.