brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.83k stars 2.33k forks source link

Embedded content settings page doesn't open correctly #37689

Open GKid94 opened 6 months ago

GKid94 commented 6 months ago

Description

YouTube showed a embedded content error and when you press the embedded content settings it opens the main Brave settings page

Steps to Reproduce

  1. Open a YouTube video until it shows a embedded content error on top right
  2. Press the embedded content error button
  3. Go to settings

Actual result:

It opens the main Brave settings page instead of embedded content settings

Expected result:

To open embedded content settings page

Reproduces how often:

Every time

Brave version (brave://version info)

1.65.114 Chromium: 124.0.6367.60 (Official Build) (64-bit)]

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

/ Screenshot 2024-04-18 185345 Screenshot 2024-04-18 185354

rebron commented 6 months ago

@GKid94 Do you have a url you can point us to where this is happening?

GKid94 commented 6 months ago

I had it on this video https://youtu.be/h3A02mrsdUc?si=YhRGseOiAKf4safM

ShivanKaul commented 6 months ago

@GKid94 could you take a screenshot of brave://flags?

mkarolin commented 3 months ago

@ShivanKaul I believe the page it's meant to lead to is brave://settings/content/storageAccess, which we hid as part of disabling kPermissionStorageAccessAPI functionality in cr124 bump when the upstream flag got removed (https://github.com/brave/brave-core/commit/3f54a899a3f748640848123aff69da4f9a94ba03).

ShivanKaul commented 3 months ago

I see, I don't think we want that still. I'm curious what would trigger that on YouTube though.

GKid94 commented 3 months ago

brave://flags

image