rebron
commented
7 months ago @Aadam-Marshall Got it thanks for filing. cc: @fallaciousreasoning, @simonhong Looks like with auto complete suggestions turned off for bookmarks and history, @bookmarks and @history shortcuts don't work and should.
Description
Below, I attached screenshots for a better understanding of my issue, see them first for a quick overview.
Earlier, it was possible to search bookmarks/history via a shortcut, while at the same time having autocomplete suggestions for them in
brave://settings/appearancedisabled. This way, if you simply type something in the address bar, you would have autocomplete from your search engine provider, and no bookmarks/history would appear there. And if you type@bookmarksin the address bar, it would switch to searching only your bookmarks. Same with@history. Now, however, I can't do that. If I disable autocomplete suggestions for bookmarks and history inbrave://settings/appearance, then even if type@bookmarksin the address bar and switch to searching my bookmarks - it won't give me any results, since autocomplete suggestions for bookmarks are now dependent on the autocomplete setting inbrave://settings/appearance. I think this behavior appeared not so long ago, but this is a broken behavior and I'm now forced to search my bookmarks via bookmark manager, which takes longer because I have to open my bookmark manager and wait for it to load, instead of just using a shortcut in the address bar. A user should be able to switch to searching their bookmarks via a shortcut, and showing the results while using a shortcut shouldn't depend on the autocomplete setting inbrave://settings/appearance. Whether the address bar shows suggestions for bookmarks via a shortcut should depend exclusively on whether a user enabled a shortcut for searching their bookmarks inbrave://settings/searchEngines. You can of course just enable the autocomplete setting for bookmarks, but this also makes the address bar to suggest you your bookmarks when in fact you just want to use your search engine and have autocomplete suggestions only from your search engine. This causes pollution and decreases the amount of autocomplete items my search engine suggests me, because they are now replaced by autocomplete suggestions from my bookmarks. I want the address bar to provide me autocomplete suggestions from my bookmarks or history only when I switch to@historyor@bookmarksshortcuts. This is how it was earlier and it was the correct behavior, because this way these settings are separated and don't depend on each other: you can have clean autocomplete suggestions in the address bar only from your search engine, and at the same time, if you want to search for your bookmarks, you simply type@bookmarks(or whatever shortcut you configure) and have the suggestions.Screenshots
@bookmarksshortcut is enabled. Autocomplete for bookmarks is enabled. Everything is ok, the address bar gives me a suggestion from my bookmarks.@bookmarksshortcut is enabled. Autocomplete for bookmarks is disabled. As you see, no autocomplete enabled = no suggestions. Autocomplete for shortcuts shouldn't depend on what is set inbrave://settings/appearance. It should only depend on whether you enabled a@bookmarksor@historyshortcut inbrave://settings/searchEngines.Steps to Reproduce
brave://settings/appearance@bookmarks/@historyshortcutsbrave://settings/appearanceExpected result:
When you search for your bookmarks or history via
@bookmarksor@historyshortcuts, the address bar should provide you with autocomplete suggestions from your bookmarks/history, and whether it shows the suggestions or not - shouldn't depend on whether you enabled autocomplete for bookmarks/history inbrave://settings/appearance.Brave version (brave://version info)
1.64.122 Chromium: 123.0.6312.122 (Official Build) (64-bit) Revision: a5b964f45dca7b87fc0f2adf2660d6fd6a6608b8 OS: Windows 10 Version 22H2 (Build 19045.4291)
Version/Channel Information:
I only use stable channel, I didn't test in other channels.