search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.73k stars 2.15k forks source link

[ads] Sometimes wrong keyframe is shown for NTT video ad #37889

Closed btlechowski closed 1 week ago

btlechowski commented 2 weeks ago

Follow up to https://github.com/brave/brave-browser/issues/37653

Steps to Reproduce

  1. Fresh install
  2. Turn off WiFi and mobile network
  3. Launch browser
  4. Toggle Use Staging CRX components in Settings -> BraveCore Switches
  5. Set rewards to staging
  6. Close the browser
  7. Turn on WiFi or mobile network
  8. Launch Brave browser
  9. Launch browser in Portrait orientation
  10. Open New Tab Pages until a tab with New Tab Takeover video ad is opened
  11. While video is playing block your phone
  12. Unblock your phone and check keyframe

Actual result:

wrong keyframe is shown

image

Expected result:

designated keyframe is shown

image

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

1.67.44 on iphone 13 pro max

cc @tmancey @aseren

kjozwiak commented 5 days ago

The above requires 1.66.103 or higher for 1.66.x verification 👍