search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.73k stars 2.15k forks source link

[ads] Sometimes close button has low contrast on NTT fullscreen video ads #37891

Open btlechowski opened 2 weeks ago

btlechowski commented 2 weeks ago

Follow up to https://github.com/brave/brave-browser/issues/37653

We should never let user have impression that they are locked in a video ad.

Steps to Reproduce

  1. Fresh install
  2. Turn off WiFi and mobile network
  3. Launch browser
  4. Toggle Use Staging CRX components in Settings -> BraveCore Switches
  5. Set rewards to staging
  6. Close the browser
  7. Turn on WiFi or mobile network
  8. Launch Brave browser
  9. Launch browser in Portrait orientation
  10. Open New Tab Pages until a tab with New Tab Takeover video ad is opened
  11. Wait till video stops playing
  12. Play the video in fullscreen
  13. Check x (close button)

Actual result:

close button has low contrast

image

Expected result:

close button has proper contrast regardless of video Maybe close button should the white circle around it, similar to play and pause buttons:

image

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

1.67.44 on iphone 13 pro max

cc @tmancey @aseren

tmancey commented 1 week ago

Blocked until a decision is made on whether this feature will become widely adopted.