search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.73k stars 2.15k forks source link

[ads] Sometimes Play and Pause button are not responsive on NTT fullscreen video ad #37893

Closed btlechowski closed 1 week ago

btlechowski commented 2 weeks ago

Follow up to https://github.com/brave/brave-browser/issues/37653

Noticed that sometimes taping on Play or Pause button yielded no response. The easiest way to reproduce is with the steps below

Steps to Reproduce

  1. Fresh install
  2. Turn off WiFi and mobile network
  3. Launch browser
  4. Toggle Use Staging CRX components in Settings -> BraveCore Switches
  5. Set rewards to staging
  6. Close the browser
  7. Turn on WiFi or mobile network
  8. Launch Brave browser
  9. Launch browser in Portrait orientation
  10. Open New Tab Pages until a tab with New Tab Takeover video ad is opened
  11. Wait till video stops playing
  12. Play the video in fullscreen
  13. Rapidly tap Play/Pause buttons

Note: issue not reproducible when taping on the video

Actual result:

Play and Pause button are not responsive

Expected result:

Play and Pause button are responsive, just like tapping next to the buttons

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

1.67.44 on iphone 13 pro max

cc @tmancey @aseren

kjozwiak commented 5 days ago

The above requires 1.66.103 or higher for 1.66.x verification 👍

Uni-verse commented 2 days ago

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.104

Note: Additional testing was on iPhone and iPad was done via https://github.com/brave/brave-browser/issues/36435#issuecomment-2103497280 & https://github.com/brave/brave-browser/issues/36435#issuecomment-2103497280

https://github.com/brave/brave-browser/assets/17885425/348ec9d8-e36a-4bbb-a0ea-8df42567c6ec