Make "Leave Sync Chain" and "Delete Sync account" more visibly separate

fmarier commented 2 weeks ago

We've had a report of a user who quickly clicked on "Leave Sync Chain" immediately after configuring the Sync data types, thinking that it was a save button: https://bravesoftware.slack.com/archives/C2HJYB45N/p1714163037164099

The "are you sure?" prompt didn't help since it was clicked through without reading.

Ideas for improvements include:

styling the dangerous buttons differently so that they don't look like "Add a new device"
making it clear to users that changes are saved immediately with a "Changes saved." kind of notice every time a toggle is clicked
adding a new heading (e.g. "Account Management" or "Danger Zone") so that the two dangerous buttons don't look like they are part of the data type selection heading

aguscruiz commented 2 weeks ago

I have an updated design here using the new style for settings, but should be easily translatable to current design.

fmarier commented 2 weeks ago

@aguscruiz That looks good.

I think it would be good to fix in SyncV2 if it's not too complicated. A SyncV2 mock would be useful.

aguscruiz commented 2 weeks ago

Sure, here's the design in V2 style. I just mocked the important part, not the whole sync page

brave / brave-browser