brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Incorrect Translation in Simplified Chinese UI #37905

Closed junkworld closed 5 months ago

junkworld commented 6 months ago

New private window with tor should be translated as 用Tor打开新的无痕窗口, not 用Tor打开新的私人窗口.

Also Settings - Privacy and Security - tor window - private window with tor should be translated as 带tor的无痕窗口, not 带tor的私人窗口.

Settings - Sheilds - Trackers & ads blocking - option Aggressive should be translated as 积极地 or 主动, not 攻击性.

Settings - Sheilds - Trackers & ads blocking - Allow Facebook logins and embedded posts should be translated as 允许Facebook登陆和嵌入帖子.

Settings - Sheilds - Trackers & ads blocking - Forget me when I close this site should be translated as 关闭此网站后遗忘我, not 关闭此网站后勿扰. In Chinese, 勿扰 means do not disturb .

Settings - Appearance - Tabs - Tab hover mode, option card should be translated as 卡片, not 信用卡. In Chinese, 信用卡 means credit card .

rebron commented 6 months ago

Thanks @junkworld

@mkarolin. @larreewong reviewed and the suggestions here are good.

mkarolin commented 6 months ago

@rebron

"New private window with tor" should be translated as "用Tor打开新的无痕窗口", not "用Tor打开新的私人窗口" .

Google translate gives me Open new private window with Tor for the current translation, but for the suggested translation I get Open a new incognito window with Tor.

Also Settings - Privacy and Security - tor window - "private window with tor " should be translated as "带tor的无痕窗口", not "带tor的私人窗口".

Similarly, for our current translation Google translate gives me Private window with tor, while the suggested translation shows as Incognito windows with tor.

rebron commented 6 months ago

Let's stick with our private language vs incognito.

mkarolin commented 6 months ago

Updated the rest in Transifex. Should get them for the upcoming 1.66.x release.

junkworld commented 6 months ago

Translate private window as 隐私窗口 is a more correct translation, In Chinese, 私人 means more "Personal", 私人 does not emphasize privacy.

The current situation is that there are too many private window words in brave settings. Some are translated as 无痕窗口 and some are translated as 私人窗口.

They are all the same words private window and have not been unified translated into the same Chinese words.

Incognito window/无痕窗口 is used in Chromium, I guess since Brave is a fork of Chromium, Brave inherited a lot of the translations in Chromium.

In Firefox, private window is translated as 隐私窗口.

junkworld commented 6 months ago

settings - system - shorcuts

There is a letter Jmissing here

图像-7

junkworld commented 6 months ago

in extensions page Web Store should be translated just as 应用商店, not Brave 网上应用店.

图像

截屏2024-05-01 19 00 21
mkarolin commented 6 months ago

Thank you @junkworld.

I've updated the Web Store strings.

With Javascript, that looks like we maybe stripping the leading J programmatically by mistake (cc: @fallaciousreasoning - the translated string is JavaScript 控制台(&J) in app/resources/generated_resources_zh-CN.xtb. We are probably removing the leading J by accident when we strip &J from the translation.)

The private vs incognito issue is not limited to just the Chinese translations. It sounds like we really need a more comprehensive effort to clean up the interchangeable use of these terms in translations @rebron, @AndyAnds265.

junkworld commented 6 months ago

I think in Appearance the first Brave colors should be renamed as Brave mode, Which matches the system's light mode and dark mode.

Brave mode should be translated as Brave 模式 in Chinese, Of course Brave mode should also be translated into any other user languages.

截屏2024-05-02 20 29 44 截屏2024-05-02 20 30 12 截屏2024-05-02 20 39 57
junkworld commented 6 months ago

Shields should not be translated, It is most appropriate to use the original English word like Leo and Web3, and the Shields after being translated as 屏蔽 is also an incorrect translation. If Shields must be translated, it should be translated as . In Chinese, 屏蔽 means block, not Shields. I think It is best to use Shields without translation. Just like ublock origin /adguard /adblock plus, they don't need to be translated into other languages.

junkworld commented 6 months ago

Hi,@mkarolin

close duplicate tabs should be translated as 关闭重复的标签页, not 关闭重复的选项卡.
Also, there are too many tab and tabs in settings, some are translated as 标签页, some are translated as 选项卡. These should all be translated as 标签页.

图像

截屏2024-05-06 14 46 23 截屏2024-05-06 14 47 30 截屏2024-05-06 14 46 05
junkworld commented 6 months ago

Hi, @mkarolin

copy clean link should be translated as 复制干净的链接 or 复制无跟踪参数链接, not 拷贝清除链接 , 复制无跟踪参数链接 is a more appropriate translation that accurately describes this feature in Chinese context,This will make it easy for users to understand the purpose of this feature.

图像-2

截屏2024-05-06 19 07 26
junkworld commented 6 months ago

vertical tabs - new tab below should be translated as 在下方新增标签页

it will be unified in format with 在右侧新增标签页/ new tab to the right

图像

图像-2

mkarolin commented 6 months ago

This should be mostly addressed by https://github.com/brave/brave-core/pull/23555

junkworld commented 6 months ago

Hi, I'm already using the 1.66.110 stable version, and I'm glad to see that many issues have been fixed. Except for those that are still not finalized, there are still some issues that have not been fixed.

Get started - New tab page shows should be translated as 新标签页显示,not 新标签页随及会显示 随及会 three words are grammatically incorrect in Chinese context,confusing and redundant,should be deleted.

Control panel - Brave 的 VPN , should be deleted, when is added,that would change its meaning to Brave's VPN,Brave's VPN and Brave VPN have completely different meanings. Settings - System - Shortcuts ,These should also be deleted, these are grammatically incorrect in Chinese context.

截屏2024-05-17 20 17 57

Privacy and security - Tor windows - Private window with Tor window should be translated as 窗口, not 窗户. All these window and windows should be translated as 窗口,somehow,this one is strangely translated as 窗户. In Chinese context, we use 窗户 to refer to a physical window in a house. This word cannot be used to refer to a window in a computer operating system. 图像

junkworld commented 5 months ago

Hi, @mkarolin

Some new issues here,

System - Shortcuts , Duplicate tab/复制标签页 Pin tab/固定标签页 Group tab/组标签页 double quotation mark (“ ”)were added by mistake, these double quotation mark(“ ”) should be deleted.

Group tab should be translated as 分组标签页, not 组标签页

添加 and 重置 should be arranged horizontally,not arranged vertically

截屏2024-05-18 15 06 05
kjozwiak commented 5 months ago

Closing the above as https://github.com/brave/brave-core/pull/23735 was merged into 1.66.x. The above requires 1.66.112 or higher for 1.66.x verification 👍

GeetaSarvadnya commented 5 months ago

Verification PASSED on

image

  1. Settings - Sheilds - Trackers & ads blocking - option Aggressive should be translated as 积极地 or 主动, not 攻击性. - PASSED image
    1. Settings - Sheilds - Trackers & ads blocking - Allow Facebook logins and embedded posts should be translated as 允许Facebook登陆和嵌入帖子. - PASSED image
  2. Settings - Sheilds - Trackers & ads blocking - Forget me when I close this site should be translated as 关闭此网站后遗忘我, not 关闭此网站后勿扰. - PASSED image
  3. Settings - Appearance - Tabs - Tab hover mode, option card should be translated as 卡片, not 信用卡 - PASSED image
junkworld commented 5 months ago

Verification PASSED on

截屏2024-05-23 14 09 15

Verified the Simplified Chinese translations from the description https://github.com/brave/brave-browser/issues/37905#issuecomment-2117407507

Get started - New tab page shows should be translated as 新标签页显示,not 新标签页随及会显示 PASSED

截屏2024-05-23 14 10 13

Control panel - Brave 的 VPN , should be deleted PASSED Settings - System - Shortcuts ,These should also be deleted PASSED

截屏2024-05-23 14 11 33 截屏2024-05-23 14 11 45

Privacy and security - Tor windows - Private window with Tor window should be translated as 窗口, not 窗户 PASSED

截屏2024-05-23 14 10 27

Verified the Simplified Chinese translations from the description https://github.com/brave/brave-browser/issues/37905#issuecomment-2119142084

System - Shortcuts , Duplicate tab/复制标签页 Pin tab/固定标签页 Group tab/组标签页 double quotation mark (“ ”)were added by mistake, these double quotation mark(“ ”) should be deleted. PASSED

截屏2024-05-23 14 11 55 截屏2024-05-23 14 12 24 截屏2024-05-23 14 12 36

Group tab should be translated as 分组标签页, not 组标签页 NOT PASSED

截屏2024-05-23 14 11 55

添加 and 重置 should be arranged horizontally,not arranged vertically NOT PASSED

截屏2024-05-23 14 12 11
mkarolin commented 5 months ago

Group tab should be translated as 分组标签页, not 组标签页 @junkworld, forgot to ask you about this .. the original string is for tab (not tabs). Google translate seems to indicate that your suggestion would mean tabs (plural).

添加 and 重置 should be arranged horizontally,not arranged vertically This is more of a layout issue, rather than a translation issue, so we would need to address that separately. cc: @fallaciousreasoning

junkworld commented 5 months ago

Group tab should be translated as 分组标签页, not 组标签页 @junkworld, forgot to ask you about this .. the original string is for tab (not tabs). Google translate seems to indicate that your suggestion would mean tabs (plural).

添加 and 重置 should be arranged horizontally,not arranged vertically This is more of a layout issue, rather than a translation issue, so we would need to address that separately. cc: @fallaciousreasoning

@mkarolin

I'm a heavy user of tab groups,I set Ctrl+G for Group tab shortcut, I found it has the same function as Add tab to New Group,no matter I select one tab, two tabs or more. Are they the same function?


And let me explain why 组标签页 is incorrect. When the single word is used as a verb in the Chinese context, there is usually only one usage of 组我组你or组他, which means to 'add me into the team','add you into the team' ,'add him into the team'. We don't add nouns after a single word ,this is a grammatically wrong sentence in Chinese context,and the plural is not applicable in this sentence in Chinese context,Google translate gives an incorrect translation. The word is usually used as part of compound words such as 分组:grouping,divide into groups,sectionalization 组织:organize,organization, 组装:assemble, 组合:combination, 组队:form a team, 组建:establish,build

If Group tab has same function as Add tab to New Group ,it is better to use that same translation向新群组中添加标签页 or just use 分组标签页

截屏2024-05-23 22 16 11
mkarolin commented 5 months ago

Hi @junkworld, thank you for the detailed explanation. I will update the translation to 分组标签页 for the next release version. Unfortunately, the text for this command is autogenerated and can't be easily mapped to `Add tab to new group' because of the way that string is constructed in the Chromium code.