brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.22k forks source link

[ads] Sometimes VAC conversion is changed to regular conversion #37944

Open btlechowski opened 2 months ago

btlechowski commented 2 months ago

I was not able to reproduce, but definitely happened. Check the logs

Steps to Reproduce

Note: exact steps unknown

  1. Convert an ad

Actual result:

VAC conversion changed to regular conversion

[14562:14562:0428/202818.363550:VERBOSE1:verifiable_conversion_id_html_meta_tag_parser_util.cc(26)] Failed to parse verifiable conversion id for <meta.*name="ad-conversion-id".*content="([-a-zA-Z0-9]*)".*> id pattern
[14562:14562:0428/202818.388274:VERBOSE1:ad_handler.cc(136)] Converted view conversion for new_tab_page_ad with creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e, creative set id a29c692e-4d51-408e-9308-2fc6b3babace, campaign id 10477b6c-eac9-4ef3-8f3b-caf4e8e83e07 and advertiser id 803953a8-56b4-4d4b-942a-fa81357f1427
[14562:14562:0428/202818.392535:VERBOSE3:account.cc(166)] Successfully processed deposit for new_tab_page_ad with creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e and conversion valued at 0
[14562:14562:0428/202818.393114:VERBOSE1:confirmations.cc(43)] Confirming conversion for new_tab_page_ad with transaction id 8ed3f685-b4de-4ffe-8f9c-8f355ca233be and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e
[14562:14562:0428/202818.468439:VERBOSE1:confirmations.cc(77)] Successfully added conversion confirmation for new_tab_page_ad with transaction id 8ed3f685-b4de-4ffe-8f9c-8f355ca233be and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e to the queue
[14562:14562:0428/202818.469472:VERBOSE1:confirmations.cc(88)] Process conversion confirmation for new_tab_page_ad with transaction id 8ed3f685-b4de-4ffe-8f9c-8f355ca233be and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e in 0 hours, 0 minutes, 5 seconds at 20:28:23.466
[14562:14562:0428/202823.483092:VERBOSE1:redeem_non_reward_confirmation.cc(57)] Redeem non-reward confirmation
[14562:14562:0428/202823.483265:VERBOSE1:redeem_non_reward_confirmation.cc(66)] Create non-reward confirmation
[14562:14562:0428/202823.483348:VERBOSE6:redeem_non_reward_confirmation.cc(71)] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/8ed3f685-b4de-4ffe-8f9c-8f355ca233be
  Content: {"conversion":[{"action":"view"}],"creativeInstanceId":"c1bbef73-5201-4ccd-9ed0-d897610d6a0e","transactionId":"8ed3f685-b4de-4ffe-8f9c-8f355ca233be","type":"conversion"}
  Content Type: application/json
  Method: kPost

37944log.txt

Expected result:

VAC conversion is not changed to regular conversion

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Brave 1.66.91 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
Revision 5c30ebba7e5e93df8fbf633585986e5e907d07e8
OS Linux

cc @tmancey @aseren @iambrianfung

tmancey commented 2 months ago

@btlechowski we will await further checks based on conversations with @iambrianfung. Thanks