brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.98k stars 2.21k forks source link

Favicons are not displayed/broken for certain ads #37993

Open MadhaviSeelam opened 2 months ago

MadhaviSeelam commented 2 months ago

Description

After enabling news during an upgrade check from 1.65.123 Chromium:124.0.6367.118 to 1.65.126 Chromium: 124.0.6367.118 in Win 11, when clicked Mint now button for Astar Network Ad, favicon is not displayed for Create an account popup. For a new install of 1.65.126 Chromium: 124.0.6367.118, favicon for Create an account popup loaded fine but the subsequent page is broken. @kjozwiak reproduced the issue on upgrade.

Steps to Reproduce

Upgrade:

  1. Installed 1.65.123 Chromium:124.0.6367.118
  2. Launched Brave
  3. Created a second profile
  4. Upgraded to 1.65.126 Chromium: 124.0.6367.118
  5. Enabled News in the second profile
  6. Clicked first ad Astar Network Ad (Mint Now button)

New Install

  1. Installed 1.65.126 Chromium: 124.0.6367.118
    1. Launched Brave
    2. Enabled News
    3. Clicked Astar Network Ad (Mint Now button)

Actual result:

Favicon is in broken state. Refresh the page/when returned to news feed tab and clicked Mint now button, favicon loaded as expected.

Upgrade profile ( 1.65.123 Chromium:124.0.6367.118 -> 1.65.126 Chromium: 124.0.6367.118)

example example example
image image image

New Install (1.65.126 Chromium: 124.0.6367.118) image (1)

Expected result:

Favicons should display as expected

example example
image (2) image

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Brave | 1.65.126 Chromium: 124.0.6367.118 (Official Build) (64-bit)
-- | --
Revision | e6a0dcfed2e939addb42f91900875679412fa5b7
OS | Windows 11 Version 23H2 (Build 22631.3527)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

@tmancey @btlechowski cc: @brave/qa-team

tmancey commented 2 months ago

@MadhaviSeelam removed feature/ads as not ads related. cc @petemill maybe you know who is best to take a look? Thanks