Closed rebron closed 6 months ago
Working for desktop. I think same change will affect on desktop and android both.
Removed iOS Release Plan
as the above was only changed for Desktop
& Android
. @rebron mentioned he'll create a follow up issue for iOS
as well as iOS
will need this change as well. CCing @iccub
PASSED
usingBrave | 1.67.73 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
-- | --
Revision | 76e7d97680074902ad7bde84f0a1a6c392a4ca6a
OS | Windows 10 Version 22H2 (Build 19045.4355)
IT
- PASSED
JA-JP
- PASSED
es-ES
- PASSED
As discussed via the Desktop
call on Tuesday, the above is being uplifted into 1.66.x
and was verified on master
at the time via https://github.com/brave/brave-core/pull/23406#issuecomment-2098870985, https://github.com/brave/brave-core/pull/23406#issuecomment-2098915109 & https://github.com/brave/brave-core/pull/23406#issuecomment-2099225845.
The above requires 1.66.104
or above for 1.66.x
verification(s) 👍
@brave/qa-team re: verification, there's STR/Cases that you can use that @LaurenWags & myself ran through via https://github.com/brave/brave-core/pull/23406#issuecomment-2098870985, https://github.com/brave/brave-core/pull/23406#issuecomment-2098915109 & https://github.com/brave/brave-core/pull/23406#issuecomment-2099225845.
For each platform, please run through the following:
Italy
casesBrave
as default and run through the cases
CA / DE / FR / GB / US / AT / ES / MX / BR / AR / IN
Brave
set as the default (Example: Poland
, China
, Romania
etc..)@Uni-verse @hffvld keep in mind that there's a C125
regression re: the incorrect SE being used in certain cases after an upgrade. It's most likely due to Bing
being changed to Microsoft Bing
. Can find the issue via https://github.com/brave/brave-browser/issues/38179.
Verified with
Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (x86_64)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | macOS Version 13.6.6 (Build 22G630)
Verification PASSED
using
Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | Windows 11 Version 23H2 (Build 22631.
IT (Italy) locale
- PASSED
BR(Brazil) locale
- PASSED
PASSED
Verification PASSED on
Brave 1.66.104 Chromium: 125.0.6422.41 (Official Build) (64-bit)
Revision 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS Linux
Verified on Galaxy Tab S8
and Pixel 7
using version(s):
Device/OS:
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.104 / 1.66.105
Chromium: 125.0.6422.41 (Official Build) (64-bit)
Description
Update search engine default for Italy:
Brave should be at the top of the drop down list at brave://settings/search
Related: https://github.com/brave/brave-browser/issues/18331, https://github.com/brave/brave-browser/issues/23814 https://github.com/brave/brave-browser/issues/26181 and https://github.com/brave/brave-browser/issues/27709
Test plan
Region set to IT
Default search engines
listRegion set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX / BR / AR / IN)
Default search engines
list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.Notes for test plan
https://github.com/brave/brave-browser/issues/23814#issuecomment-1195841652