Invalid request when using Chrome Identity API / Google OAuth Screen in the extension: Custom URI scheme is not supported on Chrome apps

jacekzlowocki commented 6 months ago

Description

We are developing a Chrome extension that utilizes Chrome Identity API (chrome.identity.getAuthToken()) to provide Google Authentication via Google OAuth screen. It works perfectly fine on Chrome browser, but not on Brave.

It seems that Brave adds it's own Custom URI scheme when creating oauth request: https://github.com/brave/brave-core/blob/9b9b01ac4a6eb7686ed971fc44bbded09b3d9175/patches/chrome-browser-extensions-api-identity-identity_get_auth_token_function.cc.patch#L97

Which is no longer supported by Google: https://developers.googleblog.com/en/improving-user-safety-in-oauth-flows-through-new-oauth-custom-uri-scheme-restrictions/

Enabling "Allow Google login for extensions" flag doesn't make any effect - still the same result.

Steps to Reproduce

In an extension, call chrome.identity.getAuthToken({ interactive: true })

Or to see it with existing extension:

Install Meeting Timer for Google Meet extension in Brave
Open extension popup and click "Sign up with Google" (this calls chrome.identity.getAuthToken({ interactive: true }))
Invalid request OAuth page opens

Actual result:

Error 400: invalid_request
Custom URI scheme is not supported on Chrome apps.

Expected result:

Actual Google OAuth screen opens, like in Chrome browser:

Reproduces how often:

Every time

Brave version (brave://version info)

1.65.126 Chromium: 124.0.6367.118 (Oficjalna wersja) (x86_64) e6a0dcfed2e939addb42f91900875679412fa5b7 macOS Wersja 14.4.1 (kompilacja 23E224)

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? No
Does the issue resolve itself when disabling Brave Rewards? No
Is the issue reproducible on the latest version of Chrome? No

astabinski commented 6 months ago

Facing the same issue 👍

beease commented 5 months ago

Same issue for me

siegerts commented 4 months ago

Also running into this issue.

LuckJMG commented 3 months ago

Same issue while trying to login on the google keep extension.

May be related to #15754.

siegerts commented 2 months ago

Just following up here to see if there are any updates?

siegerts commented 1 month ago

I put together a few posts on how to use the chrome.identity.launchWebAuthFlow as an alternative to chrome.identity.getAuthToken for enabling Google OAuth in Chrome extensions. Hopefully it helps.

brave / brave-browser