brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.76k stars 2.17k forks source link

Upgrade from Chromium 125.0.6422.26 to Chromium 125.0.6422.41. #38166

Closed mkarolin closed 1 week ago

mkarolin commented 1 week ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/125.0.6422.26..125.0.6422.41?pretty=fuller&n=10000

QA tests:

Additional checks:

kjozwiak commented 1 week ago

The above requires 1.66.104 or higher for 1.66.x verification 👍

kjozwiak commented 1 week ago

Quick overview of the work remaining re: affected areas due to C125 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/37333#issue-2225560919:

Platforms that still need to check/verify the affected areas due to C124 changes as per https://github.com/brave/brave-browser/issues/37333#issue-2225560919:

stephendonner commented 1 week ago

Verification PASSED using

Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (x86_64)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | macOS Version 14.5 (Build 23F5074a)

Brave Wallet: Solana functionality - SKIPPED/PASSED*

### See https://github.com/brave/brave-browser/issues/37333#issuecomment-2095456108 for coverage 👍

All "panels" show up correctly (VPN, Wallet, Rewards, Tipping, Shields) - PASSED

### Tipping panel - `PASSED` - Confirmed that Tipping panel works as expected - Confirmed that user can send a tip successfully - Confirmed that cross custodian tipping panel is shown as expected example | example | example | example ---------|----------|---------|--------- Screenshot 2024-05-10 at 12 00 20 PM | Screenshot 2024-05-10 at 12 01 42 PM | Screenshot 2024-05-10 at 12 01 54 PM | Screenshot 2024-05-10 at 12 01 57 PM ### Wallet - `SKIPPED/PASSED*` ### See https://github.com/brave/brave-browser/issues/37333#issuecomment-2095456108 for coverage 👍 ## Rewards - `PASSED` - Confirmed that Rewards panel works as expected - Confirmed that publisher info is shown as expected on rewards panel - Confirmed that AC notification shown as expected on BR panel example | example | example | example ---------|----------|---------|--------- Screenshot 2024-05-10 at 12 05 27 PM | Screenshot 2024-05-10 at 12 05 41 PM | Screenshot 2024-05-10 at 12 05 51 PM | Screenshot 2024-05-10 at 12 06 20 PM ## Shields - `PASSED`
- Shield panel is shown as expected in normal view Screenshot 2024-05-10 at 9 20 14 AM - Shield panel is shown as expected in advanced view Screenshot 2024-05-10 at 9 20 21 AM - Shield panel is shown as expected disabled mode Screenshot 2024-05-10 at 9 20 57 AM
## VPN - `PASSED` (Taken care of in detail in the `VPN installation on macOS works` section, below.)

Web Discovery infobar shows up correctly - PASSED

### Steps: 1. installed `1.66.104` 2. opened `brave://settings/search` 3. confirmed Brave is default search engine in `brave://settings/search` 4. entered `hello` in the URL bar ### Confirmed that `Web discovery` info bar is shown ### Confirmed that the `Web discovery` info bar looks correct and all the links/buttons on the info bar works as expected example | example | example | example ---------|----------|---------|--------- Screenshot 2024-05-09 at 1 34 20 PM | Screenshot 2024-05-09 at 1 35 16 PM | Screenshot 2024-05-09 at 1 35 20 PM | Screenshot 2024-05-09 at 1 35 26 PM

In DevTools, navigator.brave.isBrave() returns correct value (true in a Promise) - PASSED

Screenshot 2024-05-09 at 11 06 03 AM

VPN installation on macOS works - PASSED

example | example | example | example | example | example ---------|----------|---------|----------|---------|--------- Screenshot 2024-05-09 at 2 20 44 PM | Screenshot 2024-05-09 at 2 20 51 PM | Screenshot 2024-05-09 at 2 20 55 PM | Screenshot 2024-05-09 at 2 21 05 PM | Screenshot 2024-05-09 at 2 21 09 PM | Screenshot 2024-05-09 at 2 21 12 PM

Side panel UI functions as expected - PASSED

* Confirmed that Sidebar items looks correctly on the sidebar (encountered https://github.com/brave/brave-browser/issues/38109) * Confirmed that clicking on each item on sidebar works as expected Screenshot 2024-05-09 at 4 56 42 PM

Hamburger -> History -> Recent tabs showing correctly - PASSED

- Confirmed that user can see recent tabs listed under `brave://history` - Confirmed that date and time is shown correctly for the recent tabs listed under `brave://history` - Confirmed that `brave://history` is not shown on `Tor` and `Private`-window tabs `Normal`-tab history | `Tor`-tab history | `Private`-tab history ----------------------|------------------|---------------------- Screenshot 2024-05-09 at 2 59 50 PM | Screenshot 2024-05-09 at 3 01 27 PM | Screenshot 2024-05-09 at 3 01 38 PM

Brave wallet can import legacy wallet - SKIPPED/PASSED*

### See https://github.com/brave/brave-browser/issues/37333#issuecomment-2095456108 for coverage 👍

General Sync functionality - PASSED

- Verified the sync functionality in general and it works fine without any issues - When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices - Confirmed the bookmarks syched across all the devices in a sync chain - Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain - When 2 devices are in a sync chain, remove a device resets the sync chain - Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain Screenshot 2024-05-10 at 5 17 42 AM

Shields: cookies control works correctly - PASSED

**_Update the cookies setting_** - `PASSED` 1. Open a site A and and click on the site information icon and ensured that the third party cookies are blocked on the site A 2. Go to brave://settings/shields and select `Block all cookies` 3. Reload the site A and click on the site information icon and ensured that the third party cookies are blocked on the site A 4. Open the shield panel on site A and ensure that global cookies settings are applied 5. Go to brave://settings/shields and select `Allow all cookies` 6. Reload the site A and click on the site information icon and ensured that the cookies are allowed on the site A 7. Open the shield panel on site A and ensure that global cookies settings are applied **_Check Allow cookies functionality:_** - `PASSED` 1. Clean profile 1.67.x CR 125 2. Go to brave://settings/shields 3. Change cookies settings to `Block all cookies` 4. Open a site A 5. Open shields panel and ensure that block all cookies settings selected in the dropdown 6. Click on site information on a Site A and ensure that all the cookies are blocked 7. Go to brave://settings/cookies 8. Click on Add button and add a Site B to allow cookies list 9. Open site B in a NTP 10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8 11. Open shield panel for site B 12. Ensured that global cookies settings are applied as expected Case 1 - `PASSED 1. Clean profile `1.67.x - CR 125` 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block third part cookies` to `Block all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are retained Case 2 - `PASSED` 1. Continuation of case 1 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 5. Restart the browser 16 Open the site shield settings, confirmed updated cookies settings are retained Case 3 - `PASED` 1. Continuation of case 2 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Allow all cookies` to `Block third party site cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are retained

Encountered:

hffvld commented 1 week ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.104
Chromium: 125.0.6422.41 (Official Build) (64-bit) 

1 2
1 2
hffvld commented 1 week ago

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.66.104
Chromium: 125.0.6422.41 (Official Build) (64-bit) 

1 2
1 2
hffvld commented 1 week ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66 (104)
BraveCore: 1.66.104 (125.0.6422.41)

1 2
1 2
hffvld commented 1 week ago

Verified on iPad Air using version(s):

Device/OS: iPad Air / iPadOS 16.7.2
Brave build: 1.66 (104)
BraveCore: 1.66.104 (125.0.6422.41)

1 2
1 2
LaurenWags commented 1 week ago

Verified with

Brave   1.66.104 Chromium: 125.0.6422.41 (Official Build) (64-bit) 
Revision    6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS  Linux

Verified desktop affected areas listed under https://github.com/brave/brave-browser/issues/37333#issue-2225560919.

Note, the following were verified previously on Linux using 1.67.x/Nightly via https://github.com/brave/brave-browser/issues/37333#issuecomment-2095456108 by @srirambv and were not re-verified on 1.66:

Additionally, the below was skipped as it was a check specific to Windows as well as VPN is not available on Linux:

Encountered the following issues while testing:

All "panels" show up correctly (VPN, Wallet, Rewards, Tipping, Shields) - PASSED **Wallet:** - Confirmed wallet panel displays "Learn more" info before a wallet is created - Confirmed wallet panel displays wallet related info after wallet is created Example | Example --- | --- Screenshot 2024-05-10 at 2 31 56 PM | Screenshot 2024-05-10 at 2 33 11 PM **Tipping panel:** - Confirmed that Tipping panel works as expected - Confirmed that user can send a tip successfully - Confirmed that cross custodian tipping panel is shown as expected Example | Example | Example ----------|-----------|---------- Screenshot 2024-05-10 at 2 41 24 PM | Screenshot 2024-05-10 at 2 41 33 PM | Screenshot 2024-05-10 at 2 41 57 PM **Rewards**: - Confirmed that Rewards panel works as expected - Confirmed that publisher info is shown as expected on rewards panel - Confirmed that a notification is displayed on the panel as expected Example | Example | Example ----------|-----------|--------- Screenshot 2024-05-10 at 2 37 32 PM | Screenshot 2024-05-10 at 2 38 32 PM | Screenshot 2024-05-10 at 2 39 23 PM **Shields** - Shield panel is shown as expected in normal view - Shield panel is shown as expected in advanced view - Shield panel is shown as expected disabled mode Example | Example | Example ----------|-----------|---------- Screenshot 2024-05-10 at 2 44 27 PM | Screenshot 2024-05-10 at 2 44 41 PM | Screenshot 2024-05-10 at 2 44 54 PM **VPN** - Skipped as VPN is not available on Linux at this time
Web Discovery infobar shows up correctly - PASSED - Clean profile `1.66.x` RC - Open brave://settings/search - Confirmed Brave is default search engine in brave://settings/search - Enter a string "hello" in the URL bar - Confirmed that Web discovery info bar is shown - Confirmed that the Web discovery info bar looks correct and all the links/buttons on the info bar works as expected Screenshot 2024-05-10 at 2 55 24 PM
In DevTools, navigator.brave.isBrave() returns correct value (true in a Promise) - PASSED Screenshot 2024-05-10 at 3 02 45 PM
Side panel UI functions as expected - PASSED - Confirmed that Sidebar items looks correctly on the sidebar - Confirmed that click on each item on sidebar works as expected Leo | Talk | Wallet | Bookmarks | Reading List --- | --- | --- | --- | --- Screenshot 2024-05-10 at 3 43 46 PM | Screenshot 2024-05-10 at 3 44 10 PM | Screenshot 2024-05-10 at 3 44 20 PM | Screenshot 2024-05-10 at 3 45 49 PM | Screenshot 2024-05-10 at 3 45 58 PM - Spot checked that I could interact with sidebar items - Confirmed able to interact with Leo after accepting terms and conditions - Confirmed able to create a Brave Talk call - Confirmed able to import Brave Wallet - Confirmed able to navigate Bookmarks in sidebar - Confirmed able to add items to Reading List
Hamburger -> History -> Recent tabs showing correctly - PASSED 1. Confirmed that user can see recent tabs listed under the brave://history 2. Confirmed that date and time is shown correctly for the recent tabs listed under brave://history 3. Confirmed that brave://history is not shown on Tor and Private window tabs Screenshot 2024-05-13 at 8 59 51 AM
General Sync functionality - PASSED with follow up issue - Verified the sync functionality in general and it works fine without any issues - When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices - Confirmed the bookmarks synced across all the devices in a sync chain - Confirmed that bookmarks added before after the sync chain are synced across all the devices in a sync chain - Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Shields: cookies control works correctly - PASSED **_Update the cookies setting_** 1. Open a site A and and click on the site information icon and ensured that the third party cookies are blocked on the site A Screenshot 2024-05-13 at 10 27 29 AM 2. Go to brave://settings/shields and select `Block all cookies` 3. Reload the site A and click on the site information icon and ensured that the third party cookies are blocked on the site A Screenshot 2024-05-13 at 10 28 06 AM 4. Open the shield panel on site A and ensure that global cookies settings are applied Screenshot 2024-05-13 at 10 28 38 AM 5. Go to brave://settings/shields and select `Allow all cookies` 6. Reload the site A and click on the site information icon and ensured that the cookies are allowed on the site A Screenshot 2024-05-13 at 10 29 12 AM 7. Open the shield panel on site A and ensure that global cookies settings are applied Screenshot 2024-05-13 at 10 29 20 AM **_Check Allow cookies functionality:_** 1. Clean profile 1.66.x RC 2. Go to brave://settings/shields 3. Change cookies settings to `Block all cookies` 4. Open a site A 5. Open shields panel and ensure that block all cookies settings selected in the dropdown 6. Click on site information on a Site A and ensure that all the cookies are blocked Screenshot 2024-05-13 at 10 43 35 AM 7. Go to brave://settings/cookies 8. Click on Add button and add a Site B to allow cookies list Screenshot 2024-05-13 at 10 44 56 AM 9. Open site B in a NTP 10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8 Screenshot 2024-05-13 at 10 45 09 AM 11. Open shield panel for site B 12. Ensured that global cookies settings are applied as expected Screenshot 2024-05-13 at 10 45 20 AM Case 1: 1. Clean profile `1.66.x RC` 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block third part cookies` to `Block all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are retained Case 2: 1. Continuation of case 1 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are retained Case 3: 1. Continuation of case 2 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Allow all cookies` to `Block third party site cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are retained
GeetaSarvadnya commented 6 days ago

Verification PASSED on

Brave | 1.66.105 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | ba88d7bb175a55287d14014823d5da31fe9c8a47
OS | Windows 10 Version 22H2 (Build 19045.4291)

image

kjozwiak commented 4 days ago

Labelling as release-notes/exclude & QA/No in favour of https://github.com/brave/brave-browser/issues/38350.