brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.08k stars 2.23k forks source link

brave-dark-mode-block flag no longer works because fingerprinting protections can no longer be strict #38181

Open bughit opened 2 months ago

bughit commented 2 months ago

Description

brave-dark-mode-block provided more than fingerprinting protection. I don't want web content defaulting to dark just because the android theme is dark. Its an invalid assumption that the two must always be in sync. So brave-dark-mode-block provided control over this. When flipped on along with strict fingerprinting protection, web content would default to light while the android theme was dark.

Now that strict fingerprinting is gone, this flag should apply to the fingerprinting protection being on.

Additionally, I would suggest turning it into a normal setting that's independent of fingerprinting protection. Because its entirely possible to prefer light content regardless of fingerprinting.

Steps to reproduce

  1. enable dark theme in android
  2. enable chrome://flags/#brave-dark-mode-block and fingerprinting protection
  3. load github.com or google.com or reddit.com

Actual result

web content defaults to dark

Expected result

it should continue to be possible to default web content to light when the android theme is dark

Issue reproduces how often

100%

Version/Channel Information:

Device details

Brave version

1.65.126

arch-btw commented 1 month ago

Related: https://github.com/brave/brave-browser/issues/38613