brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.08k stars 2.23k forks source link

Disabling "Upgrade connections to HTTPS" works on desktop, but not on Android. #38197

Open rabinnh opened 2 months ago

rabinnh commented 2 months ago

Description

Brave on Android redirects to https even when "Upgrade connections to HTTPS" setting is set to disabled,

Steps to reproduce

  1. Open Brave browser on Android
  2. Open settings
  3. In the "Brave Shields and Privacy" find the "Upgrade connections to HTTPS"
  4. Set it to disable

Actual result

Accessing a bookmarked site using the http protocol redirects to https. Manually changing the protocol in the address bar to http and Brave still redirects to https.

Expected result

This setting works perfectly on my desktop. Desktop Brave is synced to Android Brave (FWIW).

Issue reproduces how often

Every time.

Version/Channel Information:

Brave version

1.65.126

Website problems only

Additional information

diracdeltas commented 2 months ago

cc @SergeyZhukovsky

SergeyZhukovsky commented 2 months ago

thanks @rabinnh and thanks for the ping @diracdeltas. I'm going to take a look at it.

SergeyZhukovsky commented 2 months ago

Everything works fine on my side. I tried on http://https-everywhere.badssl.com/. I attached a video below. @rabinnh what I think happened on your side is that you interacted with the website you are trying with Brave Shields. Once you touch Brave Shields(a lion's head on the URL bar) the site shields settings are going to override global settings(that's the main purpose of it). So it saved all shields settings for the website you use and HTTPS upgrades are on there. Screen_recording_20240514_144425.webm

rabinnh commented 2 months ago

Shields were off, everything I could find was off. I also cleared cache.

SergeyZhukovsky commented 2 months ago
  1. @rabinnh does http://https-everywhere.badssl.com/ got upgraded to https when global HTTPS upgrades are turned off?
  2. could you share the problem website?
  3. could you try it on beta, nightly channel(don't interact with per site shields only)?