search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.62k stars 2.29k forks source link

[ads] iOS back/forward page transitions should not trigger `NotifyTab[Text/Html]ContentDidChange` when navigating to same eTLD+1 #38273

Open aseren opened 4 months ago

aseren commented 4 months ago

Steps to Reproduce

  1. Open brave.com
  2. Tap any link which leads to webpage with brave.com eTLD+1
  3. Tap Back button
  4. Tap Forward button

Actual result:

Back/Forward transition doesn't trigger NotifyTab[Text/Html]ContentDidChange

Expected result:

Back/Forward transition triggers NotifyTab[Text/Html]ContentDidChange

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

aseren commented 4 months ago

This issue is caused by same document navigation detection implementation on iOS and should be fixed after proper same document navigation implementation. So the issue is blocked until https://github.com/brave/brave-browser/issues/38662 is resolved.