brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.79k stars 2.17k forks source link

'Move to other window' page is not shown sometimes when selecting from dialog #38277

Closed Uni-verse closed 6 days ago

Uni-verse commented 1 week ago

Description

'Move to other window' page is not shown sometimes when selecting from dialog

Intermittent issue, usually happens after opening new windows and closing one of them. Related to https://github.com/brave/brave-browser/issues/38203

Steps to reproduce

Use Case 1:

  1. New install
  2. Set Enable multiple windows to ON in Appearance settings
  3. Go back to new tab, long press on a favorite and select Open in new window
  4. Expand one of the windows (get out of split view)
  5. Open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  6. Select merge windows in the dialog

Use Case 2:

  1. New Install
  2. Set Enable multiple windows to ON in Appearance settings.
  3. Go back to new tab, long press on a favorite and select Open in new window.
  4. Repeat this to open a third window.
  5. Open menu and select Manage windows (3).
  6. Select another window.
  7. Toggle off Enable multiple windows
  8. Select merge windows on dialog

Actual result

Move to other window page is not shown, only tab itself

https://github.com/brave/brave-browser/assets/17885425/c4c1c239-7127-470b-a49f-530976c36f8f

Expected result

Should show Move to other window page

Screenshot 2024-05-13 at 12 44 37 PM

Issue reproduces how often

Intermittent

Version/Channel Information:

Device details

Brave version

1.66.105

kjozwiak commented 2 days ago

The above requires 1.66.113 or higher for 1.66.x verification(s) 👍

Uni-verse commented 1 day ago

Verified on Samsung Galaxy Tab S7 using version:

Brave   1.66.113 Chromium: 125.0.6422.76 (Official Build) (64-bit) 
Revision    b1864a9a0152d4f1631121c6b13a7426f50cf336
OS  Android 13; Build/TP1A.220624.014; 33; REL
Example Example Example
Screenshot 2024-05-22 at 11 16 14 AM Screenshot 2024-05-22 at 11 16 55 AM Screenshot 2024-05-22 at 11 17 15 AM