search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Brave crashing with "brave!brave_shields::AdBlockBaseService::ShouldStartRequest" #3839

Closed alxtrnr closed 5 years ago

alxtrnr commented 5 years ago

Description

Every time today I type anything into the omnisearch bar and press enter Brave closes. Brave also closes when navigating to a site from saved bookmarks. Can't think of anything notable I may have done leading up to this. Auto upload of crash reports now enabled.

Steps to Reproduce

  1. Open Brave
  2. Type anything onto omniscience bar
  3. press enter or
    1. Open Brave
    2. Click on a saved bookmark to open in exiting or a new tab

Actual result:

Brave closes every time after either of the above steps are followed.

Expected result:

Normal browser navigation from omnisearch or saved bookmarks

Reproduces how often:

Every time from 21/03/2019

Brave version (brave://version info)

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
JavaScript V8 7.3.492.22
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36

Reproducible on current release:

Website problems only:

Additional Information

kjozwiak commented 5 years ago

@monaxle if you go into brave://crashes do you see any crash reports that were generated?

alxtrnr commented 5 years ago

bravecrash

alxtrnr commented 5 years ago

No idea what happened but all working again now after a manual fsck this morning.

bsclifton commented 5 years ago

Awesome, thanks for the update @monaxle 😄 I'll go ahead and close, but let's re-open if you experience again

kjozwiak commented 5 years ago

Re-opening as this is still happening. @davidtemkin shared several crash stacks which are matching the one @monaxle shared in the original issue. @davidtemkin also mentioned that he's still seeing the crash on dev. So this is definitely still occurring.

Direct links to crashes from @davidtemkin:

Direct links to the crashes from @monaxle:

Looks like Brave is crashing around:

brave!brave_shields::AdBlockBaseService::ShouldStartRequest(GURL const&, content::ResourceType, std::__1::basic_string, std::__1::allocator > const&, bool*) [ad_block_base_service.cc : 134 + 0x13]

CCing @bbondy ☝️

kjozwiak commented 5 years ago

@hspencer77 ran into a crash when he was upgrading brave on macOS 10.4.4 x64. After taking a look at the crash, seems to be the same crash that @davidtemkin and @monaxle ran into, example:

Brave Browser Framework!brave_shields::AdBlockBaseService::ShouldStartRequest(GURL const&, content::ResourceType, std::__1::basic_string, std::__1::allocator > const&, bool*) [ad_block_base_service.cc : 138 + 0x13]
    rbp = 0x000070001b264870   rsp = 0x000070001b264790
    rip = 0x000000010f890e42
    Found by: previous frame's frame pointer

Crash report: https://stats.brave.com/dashboard#crash/5cae2aa20bb29e001fbc62f8

bbondy commented 5 years ago

@kjozwiak

I'm particularly interested in any crashes if they happen on a version 

=*.0.66.*
>74.0.65.66
>74.0.64.56
>74.0.63.44

If any new crashes come in for that please only post the link if the version is higher than what is listed above

kjozwiak commented 5 years ago

@asmaloney regarding https://github.com/brave/brave-browser/issues/4392 and the following crashes:

Are you using a build that meets the following criteria as per https://github.com/brave/brave-browser/issues/3839#issuecomment-484274669?

=*0.66.x*
>74.0.65.66
>74.0.64.56
>74.0.63.44
asmaloney commented 5 years ago

@kjozwiak I'm using the official release (that's keeping itself up to date):

Version 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)

asmaloney commented 5 years ago

This is still an issue and it's getting really frustrating.

Version 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit)

This time it died when restarting after installing the latest update.

Uploaded Crash Report ID 2f7589bf2464ea33 (Local Context: 6a8ce946-edd9-4e6c-b4f7-6986360084cb)

If it didn't kill all my tabs it would be... less frustrating.

asmaloney commented 5 years ago

Here's another log for you:

Uploaded Crash Report ID 786a059ef1c08f78 (Local Context: 6f0ee7f7-bcc5-4e34-b435-c88f50d886ad)

And to reiterate what happens after each crash when I launch it again:

bbondy commented 5 years ago

I think this is gone with 0.66.x and also we have a rust replacement with 0.68.x in the worst case. Closing.

asmaloney commented 5 years ago

Ironically Brave crashed (3rd time today) when I was launching it to see the email the closing of this issue generated...

macOS 10.14.5 Brave is up to date Version 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)

Uploaded Crash Report ID 01e801b3c3385d9b (Local Context: f931c8fe-ea56-4179-8134-78edff0e52d2)