Open SergeyZhukovsky opened 1 month ago
Here's what we have in settings --> appearance on iOS:
We also show a toggle on the main menu (...) when user is on a webpage:
Based on that, I would get Android closer to parity with iOS by doing the following:
(1) Update the copy for the setting under settings --> appearance
Note: I removed the and general system appearance at same time
copy. Since the Android night mode does not affect the system appearance/theme (like it does on iOS).
(2) Add a night mode checkbox to the main menu (⋮) when user is on a webpage:
find in page
settingcc @deeppandya @anthonypkeane @SergeyZhukovsky
@timchilds do we want (2) to be applied to the current page only?
@SergeyZhukovsky all pages (same as iOS).
@timchilds @SergeyZhukovsky we already have many items in the main menu. can we make the option enabled by default for now ? and add an option for each page later once we have menu redesign, we can add it in the menu. WDYT ?
Yeah I agree, I would just stop on renaming and enabling with dark theme
Looking at the GH description:
Some users mention that it's not easy to find night mode for web pages
@SergeyZhukovsky If users are not finding night mode via:
settings --> appearance
Then those same users are probably are not finding the theme changer via:
settings --> appearance --> theme
Or are you thinking Brave defaults to the system default theme and if that is dark theme then auto-enable night mode? I think some users might be confused why all the page colors are inverted by default.
To me it would makes more sense for enable night mode to auto-enable the dark theme. Like we do on iOS.
@timchilds as I understood from the community post the user is confused why he would need to switch some Night Mode after they turned on Dark Theme. The would expect Dark Theme does everything dark. Yeah I was thinking that Dark Theme that uses default OS setting would turn on web pages into dark mode as well.
If we went with that approach:
Not sure we want that deviation between the platforms. WDYT @anthonypkeane ?
Description
Some users mention that it's not easy to find night mode for web pages. We should probably enable it by default when Dark theme is on and remove Experimental from it's name. Probably name it different like
Enables dark mode for web pages content
. https://community.brave.com/t/features-related-to-web-search-in-android-browser/528233Steps to reproduce
Enable "Night Mode" (Experimental)
Actual result
Enables dark mode for web content
Expected result
Enables dark mode for web content
Reproduces how often
Easily reproduced
Brave version
1.65.x
Device
Channel information
Reproducibility
Miscellaneous information
No response