brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

[CR 126] `Share this page` icon is inherited from chrome #38601

Closed GeetaSarvadnya closed 3 months ago

GeetaSarvadnya commented 3 months ago

Description

Found while testing https://github.com/brave/brave-browser/issues/37788 CR 126 - Share this page icon is inherited from chrome

Steps to reproduce

  1. Clean profile 1.68.50 CR 126
  2. Open https://www.deutschland.de/de
  3. Observe the Share this page icon
  4. Share this page icon is inherited from chrome

Actual result

Share this page icon is inherited from chrome

image

Expected result

Share this page should have brave branded icon

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
Revision 72b186fbe4e288f53b0ee102f6ec66133b41a992
OS Windows 10 Version 22H2 (Build 19045.4412)

Channel information

Reproducibility

Miscellaneous information

cc: @brave/qa-team @rebron @emerick

GeetaSarvadnya commented 3 months ago

cc: @aguscruiz

aguscruiz commented 3 months ago

We can keep our current icon here

kjozwiak commented 3 months ago

The above requires 1.67.101 or higher for 1.67.x verification 👍

GeetaSarvadnya commented 3 months ago

Verification PASSED on

Brave | 1.67.101 Chromium: 126.0.6478.26 (Official Build) beta (64-bit)
-- | --
Revision | a561f4b53cdb831888e5cd702d2b8f9598c00f50
OS | Windows 10 Version 22H2 (Build 19045.4412)