brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.97k stars 2.21k forks source link

AI Chat - remove basic model concept #38676

Closed petemill closed 1 month ago

petemill commented 1 month ago

All models should now behave the same for non-premium users (same rate limiting), so we should not point to a basic model when rate-limited on a "freemium" model.

Test plan

When rate limited for non-premium users there should no longer be a "switch to basic model" button. This variant should be deleted. (note: this is available in storybook since it's difficult to actually trigger)

Gitchick57 commented 1 month ago

Funny, as I am trying to figure out how completely disable it on my Brave browser.  I can't stop it from providing answers to my searches when I have disabled it in settings.

May 29, 2024, 1:19 PM by @.***:

All models should now behave the same for non-premium users (same rate limiting), so we should not point to a basic model when rate-limited on a "freemium" model.

We should also instead promote the 7-day free trial of premium.

Fulfills client-side for > #37961 https://github.com/brave/brave-browser/issues/37961

— Reply to this email directly, > view it on GitHub https://github.com/brave/brave-browser/issues/38676> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A6G5JCGLFHIR6GSH2M67OD3ZEYE2DAVCNFSM6AAAAABIPLXTTOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDGOBUGA4DQOA> . You are receiving this because you are subscribed to this thread.> Message ID: > <brave/brave-browser/issues/38676> @> github> .> com>

kjozwiak commented 3 weeks ago

The above requires 1.67.109 or higher for 1.67.x verification 👍

stephendonner commented 3 weeks ago

Verified PASSED using

Brave | 1.67.109 Chromium: 126.0.6478.40 (Official Build) (x86_64)
-- | --
Revision | 98d88735f6123b755c0614e42e7868f70c35ec33
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.67.109
  2. launched Brave (no commandline args this time)
  3. opted-in to Leo
  4. clicked on Summarize this page for a few sites using Mixtral, Claude 3 Haiku, and Llama 3 8b, within an hour time-frame
  5. confirmed I hit the rate-limit dialog
  6. clicked on No thanks
  7. confirmed dialog was dismissed
  8. clicked on the Settings-gear icon in the Leo pane
  9. clicked on Claude 3 Sonnet labelled as [PREMIUM]
  10. confirmed Premium-upsell dialog
  11. clicked on Switch to the free model
  12. waited a bit (to clear rate limiting)

Confirmed

Free models

### Confirmed regular `LLama 3 8b` and other-model usage `brave://settings` | `Mixtral` | `Claude 3 Haiku` | `Claude 3 Sonnet [PREMIUM]` | ` Llama 3 8b` ----------|----------|-----------|----------|---------------- Screen Shot 2024-06-07 at 1 19 04 PM | Screen Shot 2024-06-07 at 1 22 53 PM | Screen Shot 2024-06-07 at 1 31 11 PM | (skipped, see below) | Screen Shot 2024-06-07 at 1 24 41 PM

Premium model, Claude 3 Sonnet

example | `upsell dialog` | example | example | example | example ----------|----------|-----------|----------|-------------|---------- Screen Shot 2024-06-07 at 4 22 20 PM | Screen Shot 2024-06-07 at 4 26 09 PM | Screen Shot 2024-06-07 at 1 52 38 PM | Screen Shot 2024-06-07 at 4 18 33 PM | Screen Shot 2024-06-07 at 4 20 52 PM | Screen Shot 2024-06-07 at 4 54 54 PM
GeetaSarvadnya commented 3 weeks ago

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.67.112

Clean profile

Premium user_PASSED - Clean profile 1.67.x - Opt-in Leo as a Premium user via 3 dot menu - Click on Gear icon ## Confirmed * *no* `lock` 🔒 icon in the menus - either in Leo app menu settings or the flyout menu * no `[UNLIMITED]`/`[LIMITED]` badging/labelling Example | Example -----------|--------- ![Screenshot_20240611_182753](https://github.com/brave/brave-browser/assets/38657976/baf827d0-b0c3-4510-9ef5-48d4ff35f9b0) | ![Screenshot_20240611_182759](https://github.com/brave/brave-browser/assets/38657976/650b8ad1-2551-4c13-8f82-468b4efc2cc7)
non-premium user_PASSED - Clean profile 1.67.x - Opt-in Leo as a Free user via 3 dot menu - Click on Gear icon ## Confirmed * *no* `lock` 🔒 icon in the menus - either in Leo app menu settings or the flyout menu * no `[UNLIMITED]`/`[LIMITED]` badging/labelling * only badging/labelling is for and on `Claude 3 Sonnet` as `[PREMIUM]` Example | Example -----------|--------- ![Screenshot_20240611_182855](https://github.com/brave/brave-browser/assets/38657976/d1d3b4f2-f87b-46dc-b440-3898d11c5387) | ![Screenshot_20240611_182944](https://github.com/brave/brave-browser/assets/38657976/b5698c28-8338-41ab-88ec-7f1a121805c5)

Upgrade profile

Premium user_PASSED - Clean profile 1.66.x - Opt-in Leo as a Premium user via 3 dot menu - Click on Gear icon via Leo app settings menu 1.66.x | 1.66.x -------|------- ![Screenshot_20240612_110719](https://github.com/brave/brave-browser/assets/38657976/300ac892-90df-4e64-b13b-c2c1242685ef) | ![Screenshot_20240612_110738](https://github.com/brave/brave-browser/assets/38657976/a4c7836a-9015-4fe1-b677-03fa8daf7f0b) - Upgrade the profile 1.67.x - Click on Gear icon via Leo app settings menu 1.67.x | 1.67.x -------|------- ![Screenshot_20240612_110945](https://github.com/brave/brave-browser/assets/38657976/e578d829-7120-492c-9ef2-a3e2db5b150d) | ![Screenshot_20240612_110956](https://github.com/brave/brave-browser/assets/38657976/91081b04-540d-4998-852b-7c970770f08b) ## Confirmed * *no* `lock` 🔒 icon in the menus - either in Leo app menu settings or the flyout menu * no `[UNLIMITED]`/`[LIMITED]` badging/labelling
non-premium user_PASSED - Clean profile 1.66.x - Opt-in Leo as a Free user via 3 dot menu - Click on Gear icon via Leo app settings menu 1.66.x | 1.66.x | 1.66.x -------|-------|-------- ![Screenshot_20240612_121220](https://github.com/brave/brave-browser/assets/38657976/be0e8355-e8e0-48dd-bcca-00fe9e35b96d) | ![Screenshot_20240612_121225](https://github.com/brave/brave-browser/assets/38657976/7387e9bc-ebef-4c57-919e-a1e7c60bde24) | ![Screenshot_20240612_121230](https://github.com/brave/brave-browser/assets/38657976/3c4ec351-80bc-44fb-849e-01e5e1d1ac48) - Upgrade the profile to 1.67.x - Click on Gear icon via Leo app settings menu 1.67.x | 1.67.x | 1.67.x -------|-------|--------- ![Screenshot_20240612_121317](https://github.com/brave/brave-browser/assets/38657976/b71c6ec6-b1a3-42d6-86ef-7bb6083cd075) | ![Screenshot_20240612_121323](https://github.com/brave/brave-browser/assets/38657976/01e88a60-a11f-4fca-9147-22ff50dd22b2) | ![Screenshot_20240612_121328](https://github.com/brave/brave-browser/assets/38657976/f5672d15-c4d8-4519-adcc-7905322e04c0) ## Confirmed * *no* `lock` 🔒 icon in the menus - either in Leo app menu settings or the flyout menu * no `[UNLIMITED]`/`[LIMITED]` badging/labelling * only badging/labelling is for and on `Claude 3 Sonnet` as `[PREMIUM]`