brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.02k stars 2.22k forks source link

Customize Dashboard shown on top of Brave news Dashboard when Manage feeds link in the URL clicked #38701

Open MadhaviSeelam opened 1 month ago

MadhaviSeelam commented 1 month ago

Description

After enabling news, when clicked a news card from Brave news feed, Customize Dashboard is shown on top of Brave news dashboard. This doesn't happen in current release 1.66.x or 1.67.x. Noticed in 1.68.45 (CR 125) as well.

Steps to reproduce

  1. Install 1.68.58
  2. Launch Brave
  3. enable Brave News
  4. click on any news card in the news feed
  5. click Manage subscriptions icon in the URL bar
  6. click Follow
  7. click Manage feeds

Actual result

Customize Dashboard is shown on top of Brave News Dashboard

https://github.com/brave/brave-browser/assets/98358127/6e1458bf-dcc7-47c8-b042-c0ed1e40c838

Expected result

Only Brave news dashboard should be shown

https://github.com/brave/brave-browser/assets/98358127/32e6d223-b808-47ad-93e9-718103a0c4c8

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.68.58 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
-- | --
Revision | ec786b623be34c911487c24144c0650bdd057fc1
OS | Windows 11 Version 23H2 (Build 22631.3672)

Channel information

Reproducibility

Miscellaneous information

@LorenzoMinto cc: @rebron @qa

fallaciousreasoning commented 1 month ago

Interesting - I can't seem to reproduce this on Linux dev/Nightly. Seems like it's probably some sort of race, but probably we shouldn't be opening the settings panel in the first place.